Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic single file/dir with no mixfile support #562

Merged
merged 14 commits into from
Jun 30, 2021
Merged

Conversation

lukaszsamson
Copy link
Collaborator

@lukaszsamson lukaszsamson commented Jun 27, 2021

This PR:

  • fixes some crashes when opening a single file
  • decreases warning level when no mixfile is found
  • makes sure no mixfile info is shown only once
  • fixes small logic error in build state tracking
  • fixes formatter to work for single files

addresses #307

Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great step forward ❤️

@axelson axelson merged commit 6a786d7 into master Jun 30, 2021
@axelson axelson deleted the ls-single-file branch June 30, 2021 00:14
vanjabucic pushed a commit to vanjabucic/elixir-ls that referenced this pull request Jul 5, 2021
* do not error when no mixfile

* add tests

* do not warn when no mixfile

* assert project dir is set when building

* pattern match module type

* use path api

* do nat try to return test lenses when project_dir is nil

* add assertion

* format with default options when project_dir is nil

* undo wrong assertion

* fix logic error - do not set needs_build? when build not enabled

* show no mixfile message only once instead of on every trigger_build

* run formatter

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants