Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing / harmful directions about debug_info in the README #398

Closed
al2o3cr opened this issue Dec 28, 2023 · 1 comment
Closed

Confusing / harmful directions about debug_info in the README #398

al2o3cr opened this issue Dec 28, 2023 · 1 comment

Comments

@al2o3cr
Copy link

al2o3cr commented Dec 28, 2023

The elixirc_options setting suggested in #188 has several issues:

I don't know what the root cause of the "Invalid beam file or no abstract code" error that motivated #188 was, but the only result of the change it suggests is setting debug_info to false when compiling in Mix.env == :prod since the default was already true...

@lukaszsamson
Copy link
Collaborator

Probably that README section is not relevant anymore. Since v0.15 which added official support for elixir 1.15 (elixir-lsp/elixir-ls#898), ElixirLS overwrites project settings anyway and sets debug_info, both global and test_elixirc_options, to true. IIRC it was necessary to make debugger work and tests pass.

Would you create a PR removing or updating that section?

it's unnecessary, as debug_info defaults to true

I think that's not true in tests, see https://github.com/elixir-lang/elixir/blob/38ddc98fef7faf6f4666703dcd9c99105e6388d2/lib/mix/lib/mix/compilers/test.ex#L25-L26.

lukaszsamson added a commit to elixir-lsp/elixir-ls that referenced this issue Jul 9, 2024
lukaszsamson added a commit that referenced this issue Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants