-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find elixir modules that require adding an alias #155
find elixir modules that require adding an alias #155
Conversation
|
2cc2520
to
f0efccc
Compare
a3e66a9
to
ac18bb9
Compare
ac18bb9
to
a876389
Compare
lib/elixir_sense/core/metadata.ex
Outdated
case mod_info do | ||
%State.ModFunInfo{positions: [{line, column}]} -> | ||
# Hacky :shrug | ||
{line + 1, column - 10 + 2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do these numbers represent?
I think you could extract them to variables, just to get the magic-number look out of it:
{line + 1, column - 10 + 2} | |
line_offset = 1 | |
column_offset = -8 | |
{line + line_offset, column + column_offset} |
@antedeguemon @lukaszsamson I've applied the suggestions and removed the usage of |
@antedeguemon @lukaszsamson Made a commit to fix credo errors |
Basic code to find modules that require adding an alias. Sort of related to elixir-ls issue
Marking it draft due to some known test failures that I would like to get some suggestions on how to handle them.