Add alias as additionalTextEdits #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajayvigneshk
force-pushed
the
aj/alias_additional_text_edit
branch
from
f3aebd8
to
f965d14
Compare
lukaszsamson
reviewed
Oct 2, 2022
apps/elixir_ls_debugger/mix.exs
Outdated
| @@ -25,7 +25,8 @@ defmodule ElixirLS.Debugger.Mixfile do | |||
|
|
|||
| defp deps do | |||
| [ | |||
| {:elixir_sense, github: "elixir-lsp/elixir_sense"}, | |||
| {:elixir_sense, | |||
There was a problem hiding this comment.
please revert that change
lukaszsamson
reviewed
Oct 2, 2022
| context = | ||
| case position_to_insert_alias do | ||
| {line_to_insert_alias, column_to_insert_alias} -> | ||
| # Don't know why - 1 is needed here |
There was a problem hiding this comment.
Please use SourceFile function for converting positions from utf8 1 besed to utf16 0 based. It's not trivial and it's already solved
lukaszsamson
reviewed
Oct 2, 2022
| }, | ||
| _options | ||
| ) do | ||
| detail = |
There was a problem hiding this comment.
this case is almost identical to existing one, please extract common part
lukaszsamson
reviewed
Oct 2, 2022
apps/language_server/mix.exs
Outdated
| @@ -27,7 +27,8 @@ defmodule ElixirLS.LanguageServer.Mixfile do | |||
| defp deps do | |||
| [ | |||
| {:elixir_ls_utils, in_umbrella: true}, | |||
| {:elixir_sense, github: "elixir-lsp/elixir_sense"}, | |||
| {:elixir_sense, | |||
There was a problem hiding this comment.
please revert that change
lukaszsamson
reviewed
Oct 2, 2022
mix.lock
Outdated
| @@ -1,7 +1,7 @@ | |||
| %{ | |||
| "dialyxir": {:hex, :dialyxir, "1.1.0", "c5aab0d6e71e5522e77beff7ba9e08f8e02bad90dfbeffae60eaf0cb47e29488", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "07ea8e49c45f15264ebe6d5b93799d4dd56a44036cf42d0ad9c960bc266c0b9a"}, | |||
| "docsh": {:hex, :docsh, "0.7.2", "f893d5317a0e14269dd7fe79cf95fb6b9ba23513da0480ec6e77c73221cae4f2", [:rebar3], [{:providers, "1.8.1", [hex: :providers, repo: "hexpm", optional: false]}], "hexpm", "4e7db461bb07540d2bc3d366b8513f0197712d0495bb85744f367d3815076134"}, | |||
| "elixir_sense": {:git, "https://github.com/elixir-lsp/elixir_sense.git", "08bac2a5a0ad867908d77a7087eac756bf7cce43", []}, | |||
| "elixir_sense": {:git, "https://github.com/ajayvigneshk/elixir_sense.git", "ac18bb9e1ebb7370907a355c1c7ea85314ed0878", [branch: "find_elixir_mod_requiring_alias"]}, | |||
There was a problem hiding this comment.
Please revert that change
ajayvigneshk
force-pushed
the
aj/alias_additional_text_edit
branch
from
f965d14
to
ac1c3f2
Compare
ajayvigneshk
commented
Oct 17, 2022
| assert item["kind"] == 22 | ||
| assert item["label"] == "ExampleStruct (struct)" | ||
|
|
||
| assert [%{newText: "alias ElixirLS.LanguageServer.Fixtures.ExampleStruct\n"}] = |
There was a problem hiding this comment.
The assertion before using the SourceFile module to convert positions was (notice the leading space characters)
assert [%{newText: " alias ElixirLS.LanguageServer.Fixtures.ExampleStruct\n"}] =
item["additionalTextEdits"]
|
I've done the suggestions. I'm not sure if the tests would succeed without pointing to |
lukaszsamson
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds alias to the current module as LSP's additional text edits. Essentially this PR attempts to get suggestions as mentioned in #161.
NOTE: The changes on this PR depend on elixir-lsp/elixir_sense#155 (so I've specified that as a dependency over here)The default sort order of all the modules is not useful on large projects, so some ranking (maybe based on most used modules) would be a good next step.