Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell specific launch execution #982

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

florianb
Copy link
Contributor

@florianb florianb commented Sep 20, 2023

This aims to solve #981.

I

  • moved the shell specific opts handling into dedicated exec.* scripts.
  • added a Dockerfile make it easier testing different shells (i would be able to add VSCode devcontainer support if possible).
  • added a dev docs section.

@lukaszsamson
Copy link
Collaborator

Nice. I wonder if we could add CI tests based on that dockerfile.

i would be able to add VSCode devcontainer support if possible

Not sure if I understand that. VSCode devcontainers already work with https://github.com/elixir-lsp/vscode-elixir-ls

@florianb
Copy link
Contributor Author

Nice. I wonder if we could add CI tests based on that dockerfile.

I thought about that, too - and i guess i would have done it but i couldn't manage to run the language_server.sh using fish. But yeah, i guess it is possible to have an automated test for it.

Where would you like to have that test, in a /test-directory?

Not sure if I understand that. VSCode devcontainers already work with https://github.com/elixir-lsp/vscode-elixir-ls

Yeah - sorry - i meant i could add a devcontainer setup for this project (i experimented a lot with devcontainers in the recent two years) which would allow an developer to onboard just having docker desktop and VSCode but comes at the cost of one additional directory (.devcontainer) in the project.

@lukaszsamson lukaszsamson merged commit 7eac7cf into elixir-lsp:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants