Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launch script test #987

Open
lukaszsamson opened this issue Sep 25, 2023 · 0 comments
Open

Add launch script test #987

lukaszsamson opened this issue Sep 25, 2023 · 0 comments

Comments

@lukaszsamson
Copy link
Collaborator

          > Nice. I wonder if we could add CI tests based on that dockerfile.

I thought about that, too - and i guess i would have done it but i couldn't manage to run the language_server.sh using fish. But yeah, i guess it is possible to have an automated test for it.

Where would you like to have that test, in a /test-directory?

Not sure if I understand that. VSCode devcontainers already work with https://github.com/elixir-lsp/vscode-elixir-ls

Yeah - sorry - i meant i could add a devcontainer setup for this project (i experimented a lot with devcontainers in the recent two years) which would allow an developer to onboard just having docker desktop and VSCode but comes at the cost of one additional directory (.devcontainer) in the project.

Originally posted by @florianb in #982 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant