Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing keyword completion #978

Merged

Conversation

kkalb
Copy link
Contributor

@kkalb kkalb commented Sep 4, 2023

Closes #937

added true, false and nil as keywords for completion

Missing command key in resulting item map. Any suggestions?
Also I used TDD and did not manage to test this in vsc-elixir-ls or similar yet.

Update: I replaced the submodule of vscode-elixir-ls with my fork of elixir-ls and it worked; check screenshots:

image

image

image

Also I do not know which priority they deserve.

Update 2:

May we add a new kind atom at

case kind do
...
- :value -> 12
+ :atom-> 12
+ :value -> 13
...

or

case kind do
...
- :keyword -> 14
+ :atom-> 14
+ :keyword -> 15
...

or do we leave it as

:keyword

@kkalb kkalb changed the title WIP: add missing keyword completion add missing keyword completion Sep 6, 2023
@lukaszsamson lukaszsamson merged commit cca1096 into elixir-lsp:master Sep 25, 2023
16 of 19 checks passed
@lukaszsamson
Copy link
Collaborator

I merged it. Let's see how it works in practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing keyword completions
2 participants