-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expose manipulate pipes command #521
Merged
axelson
merged 23 commits into
elixir-lsp:master
from
polvalente:fix/expose-manipulate-pipes-command
Jun 27, 2021
Merged
fix: expose manipulate pipes command #521
axelson
merged 23 commits into
elixir-lsp:master
from
polvalente:fix/expose-manipulate-pipes-command
Jun 27, 2021
Commits on Apr 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9d8e189 - Browse repository at this point
Copy the full SHA 9d8e189View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24cdfc9 - Browse repository at this point
Copy the full SHA 24cdfc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c60a98f - Browse repository at this point
Copy the full SHA c60a98fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 019bc5e - Browse repository at this point
Copy the full SHA 019bc5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c87c27d - Browse repository at this point
Copy the full SHA c87c27dView commit details
Commits on Apr 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9fc2285 - Browse repository at this point
Copy the full SHA 9fc2285View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a2ec92 - Browse repository at this point
Copy the full SHA 5a2ec92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38aca54 - Browse repository at this point
Copy the full SHA 38aca54View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4523f8 - Browse repository at this point
Copy the full SHA e4523f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for eafe746 - Browse repository at this point
Copy the full SHA eafe746View commit details
Commits on Apr 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 19f8a4f - Browse repository at this point
Copy the full SHA 19f8a4fView commit details
Commits on Apr 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e1e65e1 - Browse repository at this point
Copy the full SHA e1e65e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a20fa17 - Browse repository at this point
Copy the full SHA a20fa17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f80388 - Browse repository at this point
Copy the full SHA 3f80388View commit details
Commits on May 21, 2021
-
Make `to_pipe_at_cursor/3` public to facilitate testing. I think we should still keep some integration-level testing, but I think the majority of the test cases can be simplified. I didn't implement making `from_pipe_at_cursor/3` public, but I think it would make sense as well. Introduce `ElixirLS.LanguageServer.Protocol.TextEdit` and return it from `to_pipe_at_cursor/3` and `from_pipe_at_cursor/3` Add an example of a working simpler test, and add a few examples of broken tests (as mentioned in elixir-lsp#521 (review))
Configuration menu - View commit details
-
Copy full SHA for f1956ee - Browse repository at this point
Copy the full SHA f1956eeView commit details -
Merge pull request #1 from axelson/fix-expose-manipulate-pipes-comman…
…d-changes Proposed changes
Configuration menu - View commit details
-
Copy full SHA for 65ee05d - Browse repository at this point
Copy the full SHA 65ee05dView commit details
Commits on May 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 195c928 - Browse repository at this point
Copy the full SHA 195c928View commit details -
Configuration menu - View commit details
-
Copy full SHA for adcd0b1 - Browse repository at this point
Copy the full SHA adcd0b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6507e72 - Browse repository at this point
Copy the full SHA 6507e72View commit details
Commits on Jun 2, 2021
-
Handle more cases for manipulating pipes
Changed the function call detection to not "jump forward", as part of this if the user requests an index that is not on a function call, then no action is performed. Also fix handling of piping function calls that span multiple lines by adjusting the returned line and column to point to the correct start location by counting backward.
Configuration menu - View commit details
-
Copy full SHA for 25d0dd9 - Browse repository at this point
Copy the full SHA 25d0dd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f6719e - Browse repository at this point
Copy the full SHA 7f6719eView commit details -
Merge pull request #2 from axelson/manipulate-pipes-improvements-v2
Handle more cases for manipulating pipes Co-Authored-By: Jason Axelson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6599fb8 - Browse repository at this point
Copy the full SHA 6599fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b70a95b - Browse repository at this point
Copy the full SHA b70a95bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.