Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose manipulate pipes command #521

Merged

Commits on Apr 2, 2021

  1. Configuration menu
    Copy the full SHA
    9d8e189 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    24cdfc9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c60a98f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    019bc5e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c87c27d View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2021

  1. Configuration menu
    Copy the full SHA
    9fc2285 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a2ec92 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    38aca54 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e4523f8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    eafe746 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Configuration menu
    Copy the full SHA
    19f8a4f View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. docs: add todo comment

    polvalente committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    e1e65e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a20fa17 View commit details
    Browse the repository at this point in the history
  3. test: fix test assertion

    polvalente committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    3f80388 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Proposed changes

    Make `to_pipe_at_cursor/3` public to facilitate testing. I think we
    should still keep some integration-level testing, but I think the
    majority of the test cases can be simplified. I didn't implement making
    `from_pipe_at_cursor/3` public, but I think it would make sense as well.
    
    Introduce `ElixirLS.LanguageServer.Protocol.TextEdit` and return it from
    `to_pipe_at_cursor/3` and `from_pipe_at_cursor/3`
    
    Add an example of a working simpler test, and add a few examples of
    broken tests (as mentioned in elixir-lsp#521 (review))
    axelson committed May 21, 2021
    Configuration menu
    Copy the full SHA
    f1956ee View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from axelson/fix-expose-manipulate-pipes-comman…

    …d-changes
    
    Proposed changes
    polvalente authored May 21, 2021
    Configuration menu
    Copy the full SHA
    65ee05d View commit details
    Browse the repository at this point in the history

Commits on May 22, 2021

  1. chore: unbreak tests

    polvalente committed May 22, 2021
    Configuration menu
    Copy the full SHA
    195c928 View commit details
    Browse the repository at this point in the history
  2. fix: make tests pass

    polvalente committed May 22, 2021
    Configuration menu
    Copy the full SHA
    adcd0b1 View commit details
    Browse the repository at this point in the history
  3. test: add broken test

    polvalente committed May 22, 2021
    Configuration menu
    Copy the full SHA
    6507e72 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Handle more cases for manipulating pipes

    Changed the function call detection to not "jump forward", as part of
    this if the user requests an index that is not on a function call, then
    no action is performed.
    
    Also fix handling of piping function calls that span multiple lines by
    adjusting the returned line and column to point to the correct start
    location by counting backward.
    axelson committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    25d0dd9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f6719e View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2 from axelson/manipulate-pipes-improvements-v2

    Handle more cases for manipulating pipes
    
    Co-Authored-By: Jason Axelson <[email protected]>
    polvalente and axelson committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    6599fb8 View commit details
    Browse the repository at this point in the history
  4. chore: format code

    polvalente committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    b70a95b View commit details
    Browse the repository at this point in the history