Proposed changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `to_pipe_at_cursor/3` public to facilitate testing. I think we should still keep some integration-level testing, but I think the majority of the test cases can be simplified. I didn't implement making `from_pipe_at_cursor/3` public, but I think it would make sense as well. Introduce `ElixirLS.LanguageServer.Protocol.TextEdit` and return it from `to_pipe_at_cursor/3` and `from_pipe_at_cursor/3` Add an example of a working simpler test, and add a few examples of broken tests (as mentioned in elixir-lsp#521 (review))
polvalente
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
to_pipe_at_cursor/3public to facilitate testing. I think weshould still keep some integration-level testing, but I think the
majority of the test cases can be simplified. I didn't implement making
from_pipe_at_cursor/3public, but I think it would make sense as well.Introduce
ElixirLS.LanguageServer.Protocol.TextEditand return it fromto_pipe_at_cursor/3andfrom_pipe_at_cursor/3Add an example of a working simpler test, and add a few examples of
broken tests (as mentioned in elixir-lsp#521 (review))