Remove tmp dir from gitignore #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After elixir-lsp#463 was merged, there is nothing actually using the tmp directory for tests. And any current contributors who pull down master will still have the issue, so by removing `tmp` from .gitignore it is a signal to contributors to clean up that directory (and then their tests will work again).
lukaszsamson
approved these changes
Feb 9, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #463 was merged, there is nothing actually using the tmp directory
for tests. And any current contributors who pull down master will still
have the issue, so by removing
tmpfrom .gitignore it is a signal tocontributors to clean up that directory (and then their tests will work
again).