Fixes tests not compiling after first run #463
Conversation
| @@ -1136,7 +1136,7 @@ defmodule ElixirLS.LanguageServer.ServerTest do | |||
|
|
|||
| test "returns code lenses for runnable tests", %{server: server} do | |||
| in_fixture(__DIR__, "test_code_lens", fn -> | |||
| file_path = "test/fixture_test.exs" | |||
There was a problem hiding this comment.
I wonder if this is a good approach. mix test skips .ex files by default.
There was a problem hiding this comment.
I agree it feels a little janky and I'm not sure if it's gonna hold when we add support for ExUnit's test_paths and test_pattern.
The best solution in my opinion would be to delete the elixir_ls_utils/test/tmp folder between test runs, but I don't know if this has any ramifications I don't know about.
There was a problem hiding this comment.
So far I have not seen any negative consequences of deleting elixir_ls_utils/test/tmp. The other solution I have in mind is moving the temp folder to e.g. elixir_ls_utils/.tmp
There was a problem hiding this comment.
I hadn't thought of moving the folder, but that's a pretty good idea! I can't think of any reason why it would cause problems and my limited testing (running mix test a bunch of times in all apps and umbrella root) it seems to work fine.
After elixir-lsp#463 was merged, there is nothing actually using the tmp directory for tests. And any current contributors who pull down master will still have the issue, so by removing `tmp` from .gitignore it is a signal to contributors to clean up that directory (and then their tests will work again).
After #463 was merged, there is nothing actually using the tmp directory for tests. And any current contributors who pull down master will still have the issue, so by removing `tmp` from .gitignore it is a signal to contributors to clean up that directory (and then their tests will work again).
Fixes the issue with tests failing to compile after the first run, as described in #438. This was caused by the temporary files created by the fixture mechanism defining the module
TestCodeLensTestmultiple times in.exsfiles.Another easy fix for this would be to delete the "tmp" folder that holds the fixtures on test start. A simple
File.rm_rf!("test/tmp")inelixir_ls_utils/test/test_helper.exsdoes the trick. Not sure which solution is best. (The current solution results in warnings when running the tests becausefixture_test.exdoes not match the test pattern forelixir_ls_utils. Not a huge deal, but a little annoying)Another solution would be to get ExUnit to ignore the "tmp" folder, but I couldn't find a way to configure it in this way.
test_pathsdoes not seem to handle negative globs.This is only kind of related, but I was also wondering why it is that some fixtures, "references" for example, are used in some tests without leaving behind a temporary folder? Are the folders cleaned up manually? See here and here for examples of such tests. I am assuming that they are cleaned up automatically, but I couldn't figure out where that happens.