Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly request file watchers from client #35

Merged
merged 3 commits into from
Jun 24, 2019
Merged

Explicitly request file watchers from client #35

merged 3 commits into from
Jun 24, 2019

Conversation

daniel-koudouna
Copy link
Contributor

Fixes #34

@daniel-koudouna
Add explicit file watcher request
d7d90e0 
It is recommended that servers register for the capability to watch
files. Notably, in emacs, clients such as lsp-mode will act
conservatively and not send file change notifications without the added
message.

Added a generic capability registration request and specify file
watchers after initialization.
@daniel-koudouna
Mix format
c9e4bfb
@daniel-koudouna
Add workspace capabilities, conditionally send file watcher message
df72c0d
axelson
axelson approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! The write-up is great too.

@axelson axelson merged commit 95c021f into elixir-lsp:master Jun 24, 2019
@axelson axelson mentioned this pull request Jun 14, 2020
Merged
axelson added a commit that referenced this pull request Jun 19, 2020
@axelson
Do not advertise workspaceFolder support (#298)
5102f1c 
* Do not advertise workspaceFolder support

In #295 the user received a
warning:

> Received unmatched notification: %{"jsonrpc" => "2.0", "method" =>
  "workspace/didChangeWorkspaceFolders"

This occurs because the server advertises that it supports workspace folders:
https://microsoft.github.io/language-server-protocol/specification#workspace_workspaceFolders

This was introduced in #35 which was
actually about didChangeWatchedFiles and not workspace folders.

Fixes #296

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelson axelson axelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emacs lsp-mode not registering file watchers
2 participants
@daniel-koudouna @axelson