Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not advertise workspaceFolder support #298

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Do not advertise workspaceFolder support #298

merged 2 commits into from
Jun 19, 2020

Conversation

axelson
Copy link
Member

@axelson axelson commented Jun 14, 2020

In #295 the user received a warning:

Received unmatched notification: %{"jsonrpc" => "2.0", "method" =>
"workspace/didChangeWorkspaceFolders"

This occurs because the server advertises that it supports workspace folders:
https://microsoft.github.io/language-server-protocol/specification#workspace_workspaceFolders

This was introduced in #35 which was actually about didChangeWatchedFiles and not workspace folders.

Fixes #296

In #295 the user received a
warning:

> Received unmatched notification: %{"jsonrpc" => "2.0", "method" =>
  "workspace/didChangeWorkspaceFolders"

This occurs because the server advertises that it supports workspace folders:
https://microsoft.github.io/language-server-protocol/specification#workspace_workspaceFolders

This was introduced in #35 which was
actually about didChangeWatchedFiles and not workspace folders.

Fixes #296
@axelson axelson merged commit 5102f1c into elixir-lsp:master Jun 19, 2020
@axelson axelson deleted the do-not-advertise-workspace-folder-support branch June 19, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server says it supports workspace folders but it does not support didChangeWorkspaceFolders
2 participants