-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTP26][Windows] 0.15.1 crash or hang on start #927
Comments
Starting the
Somewhere during |
There is definitively a problem on windows. I tried on elixir 1.15 and otp 26.0.2 and didn't get a crash but it hangs. I wonder if this is related to this patch that did not make it into 1.15 elixir elixir-lang/elixir@0dd933b It seems the |
I tried patching the |
I wanted to start the language server myself, then curl the initialize command with the payload above against the language server directly to see what happens. However I don't understand language server enough to do it. 🫠 |
You need to write to stdin a message like
if you need any non ascii chars remember it needs to be encoded to latin1 |
Finally I got something useful
That doesn't look like something that SHOULD crash the LS. |
@princemaple Your request is invalid. It has to be a proper JsonRPC message like the one here ce88f3c#diff-021acf15c1baa0e6d10e0b9ff09a8903779b5188bad2748accf2238d2e4ac783 |
Also rootUri and rootPath look broken |
The message is extracted from the rpc response and replaced some of the characters for readability. I accidentally removed more than necessary :)
I used this - it is in python format, I turned it into json, maybe I did something wrong in the process. I'll try again next week. Cheers.
|
It's missing the JsonRPC wrapper |
Ah thanks 🙏
…On Fri, 30 June 2023, 23:11 Łukasz Samson, ***@***.***> wrote:
It's missing the JsonRPC wrapper {"jsonrpc":"2.0","id":0,"method":"initialize","params":
<your initialize request here>}
—
Reply to this email directly, view it on GitHub
<#927 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKEUNAP4NVXLQ3WKK3G2GDXN3GBLANCNFSM6AAAAAAZZJ5BEI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This was a tricky bug to track. On my windows machine
On OTP 25 windows and OTP 25 or OTP 26.0.2 macOS this prints
On OTP 26.0.2 windows
However if I run it directly from the cmd terminal
It prints to stdout correctly
That explains why the launcher bat works from terminal and hangs when run spawned from vscode. Note that we need to set stdout to |
OTP 26.1 is out with the fix for erlang/otp#7459, I'll test it out later |
I can confirm that elixir-ls 0.16 with OTP 26.1 is working on windows |
Environment
Current behavior
Crash after
Crash dump is uploaded
Expected behavior
After resetting back to otp 25.3 and elixir 1.15.0-otp-25, it runs without problems
The text was updated successfully, but these errors were encountered: