Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code field in form #320

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: code field in form #320

wants to merge 6 commits into from

Conversation

JaeAeich
Copy link
Contributor

Description

Add code editor, to form, this will help users take input of schema like executors etc in YAML, JSON format.

Fixes #174

Checklist

  • My code follows the contributing guidelines of this project.
  • I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • I have updated the user-facing documentation to describe any new or changed behavior.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have not reduced the existing code coverage.

Comments

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elixir-cloud-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 8:59am

Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: c5e4ff7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JaeAeich
Copy link
Contributor Author

@anuragxxd @SalihuDickson can you guys please help me figure why the css parts are not changing the label style. Checkout the styles component in the docs.

PS: I've added CSS parts and I think this might be due to a left out CSS part or some irregularity in previously existing parts.

@SalihuDickson
Copy link
Contributor

hey @JaeAeich, you can't change the style because you haven't added "label" as one of the css parts for the code component. You need to go into the code component and add a part for the label for that component, you can then export that css part as "label" in the form component.

@JaeAeich
Copy link
Contributor Author

@SalihuDickson still same, plus if you look at it the styles are getting applied in places they shouldn't be, like the border which includes the text field as well as label. Lemme know if you find something, Illl look into it as well :)

Copy link
Contributor

@SalihuDickson SalihuDickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting these (the comments in the review) should fix your issue. Since these are minor changes i didn't want to go through the trouble of creating a PR for them but if that's what you'd prefer please let me know.

packages/ecc-utils-design/src/components/code/code.ts Outdated Show resolved Hide resolved
packages/ecc-utils-design/src/components/form/form.ts Outdated Show resolved Hide resolved
packages/ecc-utils-design/src/components/form/form.ts Outdated Show resolved Hide resolved
@JaeAeich
Copy link
Contributor Author

thanks alot @SalihuDickson 🙏 please check, so I can integrate it into TES and WES.

@@ -74,6 +88,20 @@ export default function Form() {
tooltip: 'Your house number',
},
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this code component to field object below that displays the code people can copy to get the data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understand!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant to say is that you need to modify the code snippet for the complex form component to match the modifications you made to the complex form component.

packages/ecc-utils-design/demo/form/index.html Outdated Show resolved Hide resolved
packages/ecc-utils-design/src/components/form/form.ts Outdated Show resolved Hide resolved
@anuragxxd
Copy link
Member

anuragxxd commented Jun 24, 2024

Check out #324 have replaced the code component there with ace editor. @JaeAeich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add multiline support for input
3 participants