-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: code field in form #320
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@anuragxxd @SalihuDickson can you guys please help me figure why the css parts are not changing the label style. Checkout the styles component in the docs. PS: I've added CSS parts and I think this might be due to a left out CSS part or some irregularity in previously existing parts. |
hey @JaeAeich, you can't change the style because you haven't added "label" as one of the css parts for the code component. You need to go into the code component and add a part for the label for that component, you can then export that css part as "label" in the form component. |
@SalihuDickson still same, plus if you look at it the styles are getting applied in places they shouldn't be, like the border which includes the text field as well as label. Lemme know if you find something, Illl look into it as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correcting these (the comments in the review) should fix your issue. Since these are minor changes i didn't want to go through the trouble of creating a PR for them but if that's what you'd prefer please let me know.
thanks alot @SalihuDickson 🙏 please check, so I can integrate it into TES and WES. |
@@ -74,6 +88,20 @@ export default function Form() { | |||
tooltip: 'Your house number', | |||
}, | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this code component to field object below that displays the code people can copy to get the data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't understand!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant to say is that you need to modify the code snippet for the complex form component to match the modifications you made to the complex form component.
Description
Add code editor, to form, this will help users take input of schema like executors etc in
YAML
,JSON
format.Fixes #174
Checklist
Comments