Skip to content

Comments

Adjust bulk delete message#941

Merged
elie222 merged 2 commits intomainfrom
feat/bulk-delete-message
Nov 10, 2025
Merged

Adjust bulk delete message#941
elie222 merged 2 commits intomainfrom
feat/bulk-delete-message

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented Nov 10, 2025

Summary by CodeRabbit

  • New Features
    • Bulk unsubscribe and delete actions now display sender names in confirmation messages for clearer feedback
  • Bug Fixes
    • Improved email address matching when checking for previous communications
  • Chores
    • Version bumped to v2.18.14

@vercel
Copy link

vercel bot commented Nov 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
inbox-zero Ready Ready Preview Nov 10, 2025 0:28am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Walkthrough

The PR adds dynamic sender-name formatting for bulk UI actions, refines cold-email detection to use extracted sender addresses, introduces per-call scoped logging with context to Gmail provider methods, and bumps the version to v2.18.14.

Changes

Cohort / File(s) Change Summary
Bulk unsubscribe UI feedback
apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts
Adds formatSenderNames() helper function to dynamically format up to three sender names (with ellipsis for >3); uses it in toast messages for bulk archive and delete flows instead of static phrases.
Cold email detection
apps/web/utils/cold-email/is-cold-email.ts
Modifies hasPreviousCommunicationsWithSenderOrDomain call to use extractEmailAddress(email.from) instead of raw email.from, with fallback to original value if extraction fails.
Gmail logging instrumentation
apps/web/utils/email/google.ts
Introduces per-call scoped logging by creating log instances with contextual data (action, IDs, counts, sender, etc.) across multiple GmailProvider methods; propagates logger context to internal helper functions.
Version management
version.txt
Bumps version from v2.18.13 to v2.18.14.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • google.ts: While the logging instrumentation spans many methods, the pattern is repetitive and consistent. Verify that each method adds appropriate contextual fields and that logger propagation to helper functions (especially handlePreviousDraftDeletion) is correct.
  • hooks.ts: Straightforward helper function; validate the truncation logic and reuse points.
  • is-cold-email.ts: Single-line conditional change; low complexity.

Possibly related PRs

  • Retries #926: Modifies logging inside handlePreviousDraftDeletion, which this PR now receives a scoped logger instance from google.ts.
  • Show names for bulk unsub #851: Also affects bulk-unsubscribe sender display; this PR complements it by formatting sender names for toast notifications.
  • Extend logger functionality #331: Introduces the Logger.with() API that enables this PR's per-call scoped logging pattern.

Poem

🐰 Whisker-twitch at logs so bright,
Sender names formatted just right,
Cold emails parsed with care,
Context flowing everywhere,
Version hops—the future's light!

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'Adjust bulk delete message' is only partially related to the changeset. While the PR does modify bulk delete messaging, it also introduces broader changes including sender-name formatting for bulk actions, cold email detection improvements, and extensive logging enhancements across multiple files. Consider a more comprehensive title that reflects the main changes, such as 'Enhance bulk action messaging and improve logging context' or 'Add dynamic sender formatting and improve logging instrumentation'.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/bulk-delete-message

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38f10fe and ed17d2f.

📒 Files selected for processing (4)
  • apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts (3 hunks)
  • apps/web/utils/cold-email/is-cold-email.ts (1 hunks)
  • apps/web/utils/email/google.ts (17 hunks)
  • version.txt (1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use @/ for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX

Files:

  • apps/web/utils/cold-email/is-cold-email.ts
  • apps/web/utils/email/google.ts
  • apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts
!{.cursor/rules/*.mdc}

📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)

Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location

Files:

  • apps/web/utils/cold-email/is-cold-email.ts
  • version.txt
  • apps/web/utils/email/google.ts
  • apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts
**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)

**/*.ts: The same validation should be done in the server action too
Define validation schemas using Zod

Files:

  • apps/web/utils/cold-email/is-cold-email.ts
  • apps/web/utils/email/google.ts
  • apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)

**/*.{ts,tsx}: Use createScopedLogger for logging in backend TypeScript files
Typically add the logger initialization at the top of the file when using createScopedLogger
Only use .with() on a logger instance within a specific function, not for a global logger

Import Prisma in the project using import prisma from "@/utils/prisma";

**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.

Files:

  • apps/web/utils/cold-email/is-cold-email.ts
  • apps/web/utils/email/google.ts
  • apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts
apps/web/utils/**

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Create utility functions in utils/ folder for reusable logic

Files:

  • apps/web/utils/cold-email/is-cold-email.ts
  • apps/web/utils/email/google.ts
apps/web/utils/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle size

Files:

  • apps/web/utils/cold-email/is-cold-email.ts
  • apps/web/utils/email/google.ts
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{js,jsx,ts,tsx}: Don't use elements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...

Files:

  • apps/web/utils/cold-email/is-cold-email.ts
  • apps/web/utils/email/google.ts
  • apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts
!pages/_document.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.

Files:

  • apps/web/utils/cold-email/is-cold-email.ts
  • version.txt
  • apps/web/utils/email/google.ts
  • apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts
apps/web/app/**

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

NextJS app router structure with (app) directory

Files:

  • apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts
apps/web/app/(app)/*/**

📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)

Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder

Files:

  • apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts
🧠 Learnings (7)
📚 Learning: 2025-07-18T15:05:34.899Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/gmail-api.mdc:0-0
Timestamp: 2025-07-18T15:05:34.899Z
Learning: Applies to apps/web/utils/gmail/**/*.ts : Keep provider-specific implementation details isolated in the appropriate utils subfolder (e.g., 'apps/web/utils/gmail/')

Applied to files:

  • apps/web/utils/email/google.ts
📚 Learning: 2025-09-17T22:05:28.646Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/llm.mdc:0-0
Timestamp: 2025-09-17T22:05:28.646Z
Learning: Applies to apps/web/utils/ai/**/*.{ts,tsx} : Use descriptive scoped loggers for each feature

Applied to files:

  • apps/web/utils/email/google.ts
📚 Learning: 2025-09-17T22:05:28.646Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/llm.mdc:0-0
Timestamp: 2025-09-17T22:05:28.646Z
Learning: Applies to apps/web/utils/ai/**/*.{ts,tsx} : Log inputs and outputs with appropriate log levels and include relevant context

Applied to files:

  • apps/web/utils/email/google.ts
📚 Learning: 2025-09-17T22:05:28.646Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/llm.mdc:0-0
Timestamp: 2025-09-17T22:05:28.646Z
Learning: Applies to apps/web/utils/ai/**/*.{ts,tsx} : Use proper error types and logging for failures

Applied to files:

  • apps/web/utils/email/google.ts
📚 Learning: 2025-07-18T15:06:47.625Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/logging.mdc:0-0
Timestamp: 2025-07-18T15:06:47.625Z
Learning: Applies to **/*.{ts,tsx} : Use `createScopedLogger` for logging in backend TypeScript files

Applied to files:

  • apps/web/utils/email/google.ts
📚 Learning: 2025-07-18T15:06:47.625Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/logging.mdc:0-0
Timestamp: 2025-07-18T15:06:47.625Z
Learning: Applies to **/*.{ts,tsx} : Only use `.with()` on a logger instance within a specific function, not for a global logger

Applied to files:

  • apps/web/utils/email/google.ts
📚 Learning: 2025-07-18T15:06:47.625Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/logging.mdc:0-0
Timestamp: 2025-07-18T15:06:47.625Z
Learning: Applies to **/*.{ts,tsx} : Typically add the logger initialization at the top of the file when using `createScopedLogger`

Applied to files:

  • apps/web/utils/email/google.ts
🧬 Code graph analysis (3)
apps/web/utils/cold-email/is-cold-email.ts (1)
apps/web/utils/email.ts (1)
  • extractEmailAddress (19-52)
apps/web/utils/email/google.ts (3)
apps/web/utils/gmail/mail.ts (1)
  • draftEmail (240-279)
apps/web/utils/ai/choose-rule/draft-management.ts (1)
  • handlePreviousDraftDeletion (10-113)
apps/web/utils/gmail/message.ts (1)
  • getMessages (257-286)
apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts (1)
apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/types.ts (1)
  • Row (6-12)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: cubic · AI code reviewer
🔇 Additional comments (13)
version.txt (1)

1-1: LGTM!

Version bump to v2.18.14 is appropriate for this release.

apps/web/utils/cold-email/is-cold-email.ts (1)

61-61: LGTM! Improved sender identity matching.

Using extractEmailAddress normalizes the sender identity before checking for previous communications, which should improve matching accuracy. The fallback to email.from ensures robustness.

apps/web/app/(app)/[emailAccountId]/bulk-unsubscribe/hooks.ts (3)

683-688: LGTM! Good refactoring to reduce duplication.

The helper function consolidates sender name formatting logic used in toast messages for bulk operations. The implementation correctly handles the 3-name limit with ellipsis truncation.


428-436: LGTM! Improved toast messaging.

The dynamic sender names in toast messages provide better user feedback compared to generic messages.


534-547: LGTM! Consistent bulk delete messaging.

The toast messages now match the pattern used in bulk archive, providing consistent UX.

apps/web/utils/email/google.ts (8)

244-265: LGTM! Proper scoped logging added.

The per-call scoped logger with action and messageId context follows the coding guidelines and improves observability.

Based on learnings.


268-287: LGTM! Consistent logging pattern.

Scoped logging with context is properly applied to the bulk archive operation.


295-370: LGTM! Rich contextual logging.

The scoped logger includes comprehensive context (emailAccountId, email, sendersCount) and properly logs throughout the bulk operation lifecycle.

Based on learnings.


377-483: LGTM! Proper error logging in bulk operation.

The scoped logger with context properly tracks the multi-stage bulk trash operation, including detailed error handling for individual thread and sender failures.


527-573: LGTM! Enhanced logging with fallback tracking.

The scoped logger properly tracks both the primary labeling operation and the fallback logic when labels aren't found by ID.


589-612: LGTM! Logger propagation to helper function.

Properly creates a scoped logger and passes it to handlePreviousDraftDeletion for consistent contextual logging across the draft management flow.

Based on learnings.


967-987: LGTM! Proper logging for reply check.

The scoped logger with sender context and result logging provides good observability for the reply sent check.


993-1016: LGTM! Comprehensive logging for message counting.

The scoped logger properly tracks the entire message count operation with relevant context (sender, threshold, count).

Based on learnings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@elie222 elie222 merged commit 5ca8755 into main Nov 10, 2025
15 checks passed
@elie222 elie222 deleted the feat/bulk-delete-message branch December 18, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant