Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis PR changes AI generation APIs to accept an Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as App code (AI call site)
participant LLM as llms.createGenerate{Text|Object}
participant Model as LLM runtime
participant Handler as llms.handleError
participant PostHog as posthog.trackError
Caller->>LLM: call with { emailAccount, label, modelOptions }
LLM->>Model: generate
alt success
Model-->>LLM: result
LLM-->>Caller: result
else error
Model-->>LLM: error
LLM->>Handler: handleError(error, emailAccount.email, emailAccount.id, label, modelName)
Handler->>PostHog: trackError({ email: emailAccount.email, emailAccountId: emailAccount.id, ... })
Handler-->>Caller: throw / fallback
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used📓 Path-based instructions (2)!{.cursor/rules/*.mdc}📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Files:
!pages/_document.{js,jsx,ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
Files:
🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/web/utils/middleware.ts (1)
105-105: Consider extracting emailAccountId from request when available.The hardcoded
"unknown"value is a placeholder (as indicated by the TODO comment). You could improve this by attempting to extract theemailAccountIdfrom the request when it's available:- await logErrorToPosthog("api", req.url, apiError.type, "unknown"); // TODO: add emailAccountId + const emailAccountId = + "auth" in req && "emailAccountId" in (req as RequestWithEmailAccount).auth + ? (req as RequestWithEmailAccount).auth.emailAccountId + : "unknown"; + await logErrorToPosthog("api", req.url, apiError.type, emailAccountId);This would provide better telemetry for errors that occur in requests with email account context, while still falling back to "unknown" for unauthenticated or non-account-specific requests.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 49 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/web/utils/logger.ts">
<violation number="1" location="apps/web/utils/logger.ts:136">
Returning errorFull here forwards the unsanitized Error object to Axiom in production, undoing the sanitization this function was meant to enforce. Please avoid sending the raw error.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
There was a problem hiding this comment.
Reviewed changes from recent commits (found 1 issue).
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/web/utils/logger.ts">
<violation number="1" location="apps/web/utils/logger.ts:145">
Serializing the Error into a plain object drops non-enumerable fields like `.cause`, so nested error context is lost in production logs.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| function serializeError(error: unknown): unknown { | ||
| if (error instanceof Error) { | ||
| // Convert Error instance to plain object so hashSensitiveFields can process it | ||
| const serialized: Record<string, unknown> = { |
There was a problem hiding this comment.
Serializing the Error into a plain object drops non-enumerable fields like .cause, so nested error context is lost in production logs.
Prompt for AI agents
Address the following comment on apps/web/utils/logger.ts at line 145:
<comment>Serializing the Error into a plain object drops non-enumerable fields like `.cause`, so nested error context is lost in production logs.</comment>
<file context>
@@ -130,13 +130,37 @@ function formatError(args?: Record<string, unknown>) {
+function serializeError(error: unknown): unknown {
+ if (error instanceof Error) {
+ // Convert Error instance to plain object so hashSensitiveFields can process it
+ const serialized: Record<string, unknown> = {
+ name: error.name,
+ message: error.message,
</file context>
1 participant
Summary by CodeRabbit
Bug Fixes
Improvements
Other