Don't load threads for outlook draft

[elie222]

Summary by CodeRabbit

• Bug Fixes

  • Fixed Outlook thread message retrieval to exclude draft messages from results.
  • Improved message data consistency and handling in thread conversations.

• Chores

  • Version bumped to v2.17.36.

[coderabbitai]

Walkthrough

This change refactors Outlook thread message retrieval to centralize message conversion using convertMessage and folder ID lookup via getFolderIds. The getThread request now selects additional fields, and the getThreadMessages function asynchronously converts messages while filtering out drafts, replacing prior manual field mapping.

Changes

Cohort / File(s)	Summary
Outlook thread refactoring apps/web/utils/outlook/thread.ts	Added imports for convertMessage and getFolderIds. Updated getThread to request additional fields (id, conversationId, conversationIndex, subject, bodyPreview, from, sender, toRecipients, receivedDateTime, isDraft, isRead, body, categories, parentFolderId). Refactored getThreadMessages to fetch folder IDs asynchronously and use centralized convertMessage for message conversion; drafts are now filtered from results.
Version bump version.txt	Bumped version from v2.17.35 to v2.17.36.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant getThreadMessages
    participant getFolderIds
    participant convertMessage
    participant API

    Caller->>getThreadMessages: Request thread messages
    getThreadMessages->>API: Fetch thread messages
    API-->>getThreadMessages: Message data
    
    Note over getThreadMessages: Filter drafts
    
    getThreadMessages->>getFolderIds: Fetch folder IDs asynchronously
    getFolderIds-->>getThreadMessages: Folder IDs
    
    loop For each non-draft message
        getThreadMessages->>convertMessage: Convert message with folderIds
        convertMessage-->>getThreadMessages: Converted message
    end
    
    getThreadMessages-->>Caller: Converted messages array

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Verify the async getFolderIds call doesn't introduce race conditions or performance issues
• Confirm convertMessage properly handles all required fields now selected in getThread
• Validate that draft filtering logic correctly identifies and excludes draft messages
• Check for any edge cases where convertMessage behavior may differ from prior manual mapping

Possibly related PRs

• #839: Centralizes message conversion and folder-id usage across Outlook message handling with similar refactoring patterns to this change.
• #836: Modifies the same getFolderIds utility function and related Outlook webhook flows, directly intersecting with the utilities introduced here.
• #590: Updates Outlook message/thread handling with conversationIndex propagation, relating to the additional fields now requested in thread retrieval.

Suggested reviewers

• mosesjames7271-svg

Poem

🐰 Threads once tangled, now refined,
FolderIds and messages combined,
Drafts fade away, conversions align,
Centralized wisdom—the code looks divine! ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: filtering out Outlook draft messages from thread retrieval, which aligns with the core modification in getThreadMessages.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/outlook-thread-without-draft

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b19fa5f and f0eabc1.

📒 Files selected for processing (2)

• apps/web/utils/outlook/thread.ts (3 hunks)
• version.txt (1 hunks)

🧰 Additional context used

📓 Path-based instructions (8)

!{.cursor/rules/*.mdc}

📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)

Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location

Files:

• version.txt
• apps/web/utils/outlook/thread.ts

!pages/_document.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.

Files:

• version.txt
• apps/web/utils/outlook/thread.ts

apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use @/ for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX

Files:

• apps/web/utils/outlook/thread.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)

**/*.ts: The same validation should be done in the server action too
Define validation schemas using Zod

Files:

• apps/web/utils/outlook/thread.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)

**/*.{ts,tsx}: Use createScopedLogger for logging in backend TypeScript files
Typically add the logger initialization at the top of the file when using createScopedLogger
Only use .with() on a logger instance within a specific function, not for a global logger

Import Prisma in the project using import prisma from "@/utils/prisma";

**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.

Files:

• apps/web/utils/outlook/thread.ts

apps/web/utils/**

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Create utility functions in utils/ folder for reusable logic

Files:

• apps/web/utils/outlook/thread.ts

apps/web/utils/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle size

Files:

• apps/web/utils/outlook/thread.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{js,jsx,ts,tsx}: Don't use elements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...

Files:

• apps/web/utils/outlook/thread.ts

🧬 Code graph analysis (1)

apps/web/utils/outlook/thread.ts (1)

apps/web/utils/outlook/message.ts (2)

• getFolderIds (81-113)
• convertMessage (468-492)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: test
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (4)

version.txt (1)

1-1: LGTM!

Standard version bump to accompany the code changes in this PR.

apps/web/utils/outlook/thread.ts (3)

6-6: LGTM!

The new imports support the refactored getThreadMessages function, centralizing message conversion logic and folder ID retrieval.

---

22-24: LGTM!

Explicit field selection improves clarity and ensures all fields needed for draft filtering and message conversion are retrieved.

---

193-197: No issues found—code change is safe.

Verification confirmed that no callers depend on drafts being included. All usages of getThreadMessages process returned messages uniformly without any draft-specific handling. Filtering drafts at the source in the implementation (rather than requiring every caller to filter) is a cleaner approach that aligns with the PR intent.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 2 files