Skip to content

Comments

fix: Fix and update outlook thread detection and scheduled action outlook compatibility#590

Merged
elie222 merged 2 commits intoelie222:stagingfrom
edulelis:fix-outlook-thread-and-scheduled-action
Jul 23, 2025
Merged

fix: Fix and update outlook thread detection and scheduled action outlook compatibility#590
elie222 merged 2 commits intoelie222:stagingfrom
edulelis:fix-outlook-thread-and-scheduled-action

Conversation

@edulelis
Copy link
Collaborator

@edulelis edulelis commented Jul 23, 2025

Summary by CodeRabbit

  • New Features

    • Added support for handling and exposing the conversationIndex property in email message data, enabling more accurate thread and reply detection.
  • Refactor

    • Replaced the isReplyInThread boolean with a more flexible approach using conversationIndex for determining reply status.
    • Updated scheduled action execution to use a generalized email provider interface, improving compatibility and maintainability.
  • Bug Fixes

    • Improved accuracy in identifying replies within email threads by leveraging message metadata.
  • Chores

    • Updated type definitions and interfaces to reflect changes in message structure and properties.

@vercel
Copy link

vercel bot commented Jul 23, 2025

@edulelis is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 23, 2025

Walkthrough

The changes refactor how the code determines if an email is a reply within a thread. The boolean property isReplyInThread is removed from message representations and replaced with an optional conversationIndex string. Thread reply logic is centralized in a new isReplyInThread utility, and email provider abstraction is introduced for scheduled actions.

Changes

File(s) Change Summary
apps/web/utils/types.ts ParsedMessage interface: replace isReplyInThread: boolean with conversationIndex?: string.
apps/web/utils/mail.ts Remove isReplyInThread property from parseMessage return object.
apps/web/utils/outlook/message.ts Remove isReplyInThread logic; add/export isOutlookReplyInThread; pass conversationIndex instead of boolean.
apps/web/utils/thread.ts Add new utility function isReplyInThread to determine reply status using IDs and conversationIndex.
apps/web/utils/ai/choose-rule/match-rules.ts Replace property check with call to new isReplyInThread utility.
apps/web/app/api/outlook/webhook/process-history-item.ts Include conversationIndex in processed message objects.
apps/web/utils/scheduled-actions/executor.ts Accept EmailProvider client; refactor to use provider, update message mapping.
apps/web/app/api/scheduled-actions/execute/route.ts Use createEmailProvider; fetch account data; pass provider to execution.

Sequence Diagram(s)

sequenceDiagram
    participant API as API Route
    participant Provider as EmailProvider
    participant Executor as executeScheduledAction
    participant Util as isReplyInThread

    API->>Provider: createEmailProvider(account)
    API->>Executor: executeScheduledAction(scheduledAction, Provider)
    Executor->>Provider: getMessage(...)
    Executor->>Util: isReplyInThread(messageId, threadId, conversationIndex)
    Util-->>Executor: reply status (boolean)
    Executor-->>API: action result
Loading

Estimated code review effort

3 (~45 minutes)

Possibly related PRs

  • fix: Fix outlook thread detection #589: Both PRs modify how thread reply status is determined, transitioning between isReplyInThread and conversationIndex, and affect overlapping code in message utilities.

Poem

In the warren of code, replies once hid,
With booleans gone, new strings slid.
Now rabbits hop through threads with glee,
Following conversation indices, wild and free!
With a twitch of the nose and a flick of the ear,
The inbox is clearer—let’s all give a cheer!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@elie222 elie222 merged commit 5ac3511 into elie222:staging Jul 23, 2025
7 of 9 checks passed
@edulelis edulelis deleted the fix-outlook-thread-and-scheduled-action branch July 24, 2025 18:14
@coderabbitai coderabbitai bot mentioned this pull request Aug 8, 2025
@coderabbitai coderabbitai bot mentioned this pull request Sep 2, 2025
This was referenced Oct 6, 2025
@coderabbitai coderabbitai bot mentioned this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants