Update pricing sectiona and clean up old code/tests#764
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoves feature-flag gating for delayed actions and landing layout variants, simplifies pricing layout and tier config, adds a testimonial component/section, replaces A/B onboarding redirects with a fixed redirect, deletes unused layout/redirect components and flag hooks, updates a marketing submodule pointer, and bumps the version. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Page as welcome-redirect/page.tsx
participant Auth as Access Checks
participant Router as Next.js Router
User->>Page: Request /welcome-redirect
Page->>Auth: Validate access/session
alt Not allowed
Page-->>Router: redirect("/login" | other)
else Allowed
Note over Page: Variant-based logic removed
Page-->>Router: redirect("/onboarding")
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
apps/web/app/(app)/premium/Pricing.tsx (2)
261-266: Return early after redirecting unauthenticated users.Otherwise we still attempt checkout/portal calls for logged-out users.
- if (!isLoggedIn) router.push("/login"); + if (!isLoggedIn) { + router.push("/login"); + return; + }
300-305: Remove console usage; surface errors to users.Guidelines disallow
console. UsetoastError(and optionally capture to your error reporter).- } catch (error) { - console.error(error); + } catch (error) { + toastError({ + description: + (error as Error)?.message ?? + "Something went wrong. Please try again or contact support.", + });
🧹 Nitpick comments (8)
apps/web/app/(landing)/welcome-upgrade/page.tsx (1)
12-14: Nit: polish testimonial copyMinor grammar tweak improves readability.
- <blockquote className="text-xl font-semibold text-gray-900 sm:text-2xl lg:text-3xl leading-relaxed"> - "We save 60+ hours weekly and let us grow from 20 to 50 employees. - It's like having an assistant that never sleeps." - </blockquote> + <blockquote className="text-xl font-semibold text-gray-900 sm:text-2xl lg:text-3xl leading-relaxed"> + “We save 60+ hours weekly, and it helped us grow from 20 to 50 employees. + It's like having an assistant that never sleeps.” + </blockquote>Also applies to: 20-36
apps/web/app/(app)/premium/config.ts (1)
181-187: Nit: tighten tooltip wording“Store up to unlimited content” is redundant.
- tooltip: - "The knowledge base is used to help draft responses. Store up to unlimited content in your knowledge base.", + tooltip: + "The knowledge base helps draft responses. Store unlimited content in your knowledge base.",apps/web/app/(app)/premium/Pricing.tsx (6)
140-155: Fix conflicting Tailwind gaps (gap-y-8 overridden by gap-4).
gap-4resets row gap back to 1rem; use column-only gap.- <div className="isolate mx-auto mt-10 grid max-w-7xl grid-cols-1 gap-y-8 lg:mx-0 lg:max-w-none lg:grid-cols-3 gap-4"> + <div className="isolate mx-auto mt-10 grid max-w-7xl grid-cols-1 gap-y-8 lg:mx-0 lg:max-w-none lg:grid-cols-3 gap-x-4">
274-279: Normalize hasActiveStripeSubscription to a boolean.Current
&&chain yieldsstring | boolean | null | undefined; coerce explicitly.- const hasActiveStripeSubscription = - stripeSubscriptionId && - stripeSubscriptionStatus && - ["active", "trialing"].includes(stripeSubscriptionStatus); + const hasActiveStripeSubscription = Boolean( + stripeSubscriptionId && + ["active", "trialing"].includes(stripeSubscriptionStatus ?? "") + );
189-193: Drop redundant key on non-list element.
keyhere has no effect; it’s already set on the mapped<PriceTier>.- <ThreeColItem - key={tier.name} - className="flex flex-col rounded-3xl bg-white p-8 ring-1 ring-gray-200 xl:p-10" - > + <ThreeColItem className="flex flex-col rounded-3xl bg-white p-8 ring-1 ring-gray-200 xl:p-10">
196-204: Use a safe, slugified id for aria-describedby.
idfromtier.namemay contain spaces; slugify inline to avoid invalid IDs.- <h3 - id={tier.name} + <h3 + id={tier.name.replace(/\s+/g, "-").toLowerCase()} className={cn( tier.mostPopular ? "text-blue-600" : "text-gray-900", "font-cal text-lg leading-8", )} >- aria-describedby={tier.name} + aria-describedby={tier.name.replace(/\s+/g, "-").toLowerCase()}Also applies to: 307-308
135-137: Avoid hard-coding “Save up to 16%”. Compute from config or hide when 0.This can drift from
tiersdiscounts after config changes.- <Badge>Save up to 16%</Badge> + {maxDiscount > 0 ? <Badge>Save up to {maxDiscount}%</Badge> : null}Add near the top of
Pricing:const maxDiscount = Math.max( ...tiers.flatMap((t) => [ t.discount?.monthly ?? 0, t.discount?.annually ?? 0, ]), );Please confirm current max discount in
apps/web/app/(app)/premium/config.ts.
334-334: ThreeColItem adds no behavior; consider inlining or using a semantic wrapper.You can inline the
divor switch to a semantic<article>/shadcn Card.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
apps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsx(1 hunks)apps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsx(2 hunks)apps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsx(2 hunks)apps/web/app/(app)/premium/Pricing.tsx(3 hunks)apps/web/app/(app)/premium/config.ts(4 hunks)apps/web/app/(landing)/home/ContentLayout.tsx(0 hunks)apps/web/app/(landing)/page.tsx(1 hunks)apps/web/app/(landing)/welcome-redirect/content.tsx(0 hunks)apps/web/app/(landing)/welcome-redirect/page.tsx(1 hunks)apps/web/app/(landing)/welcome-upgrade/page.tsx(1 hunks)apps/web/app/(marketing)(1 hunks)apps/web/components/PersonWithLogo.tsx(1 hunks)apps/web/hooks/useFeatureFlags.ts(0 hunks)version.txt(1 hunks)
💤 Files with no reviewable changes (3)
- apps/web/app/(landing)/home/ContentLayout.tsx
- apps/web/app/(landing)/welcome-redirect/content.tsx
- apps/web/hooks/useFeatureFlags.ts
🧰 Additional context used
📓 Path-based instructions (16)
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/components/PersonWithLogo.tsxapps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/config.tsapps/web/app/(app)/premium/Pricing.tsx
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/app/(marketing)apps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/config.tsapps/web/app/(app)/premium/Pricing.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/components/PersonWithLogo.tsxapps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/Pricing.tsx
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/app/(marketing)version.txtapps/web/components/PersonWithLogo.tsxapps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/config.tsapps/web/app/(app)/premium/Pricing.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/components/PersonWithLogo.tsxapps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/Pricing.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/components/PersonWithLogo.tsxapps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/config.tsapps/web/app/(app)/premium/Pricing.tsx
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/Pricing.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/components/PersonWithLogo.tsxapps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/config.tsapps/web/app/(app)/premium/Pricing.tsx
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/app/(marketing)version.txtapps/web/components/PersonWithLogo.tsxapps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/config.tsapps/web/app/(app)/premium/Pricing.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/components/PersonWithLogo.tsxapps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/Pricing.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(landing)/welcome-redirect/page.tsxapps/web/components/PersonWithLogo.tsxapps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(landing)/welcome-upgrade/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(landing)/page.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/Pricing.tsxapps/web/components/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Use React Hook Form with Zod validation for form handling
Use the
LoadingContentcomponent to handle loading and error states consistently in data-fetching components.Use PascalCase for components (e.g.
components/Button.tsx)Files:
apps/web/components/PersonWithLogo.tsxapps/web/app/(app)/*/**
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder
Files:
apps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/config.tsapps/web/app/(app)/premium/Pricing.tsxapps/web/app/(app)/*/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If you need to use onClick in a component, that component is a client component and file must start with 'use client'
Files:
apps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/Pricing.tsxapps/web/app/(app)/*/**/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If we're in a deeply nested component we will use swr to fetch via API
Files:
apps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsxapps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsxapps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsxapps/web/app/(app)/premium/Pricing.tsx**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.ts: The same validation should be done in the server action too
Define validation schemas using ZodFiles:
apps/web/app/(app)/premium/config.ts🧠 Learnings (3)
📚 Learning: 2025-08-10T22:03:30.507Z
Learnt from: elie222 PR: elie222/inbox-zero#667 File: apps/web/app/(app)/[emailAccountId]/onboarding/page.tsx:18-25 Timestamp: 2025-08-10T22:03:30.507Z Learning: In Next.js 15, both `params` and `searchParams` passed to page components in the App Router are Promises that need to be awaited. They should be typed as `Promise<{...}>` and accessed using `await` in server components or React's `use()` hook in client components. This is different from Next.js 14 where they were plain objects.Applied to files:
apps/web/app/(landing)/welcome-redirect/page.tsx📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR PR: elie222/inbox-zero#0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/components/**/*.tsx : Use React Hook Form with Zod validation for form handlingApplied to files:
apps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsx📚 Learning: 2025-07-18T15:05:16.146Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/fullstack-workflow.mdc:0-0 Timestamp: 2025-07-18T15:05:16.146Z Learning: Applies to apps/web/components/**/*Form.tsx : Use React Hook Form with Zod resolver for form handling and validation.Applied to files:
apps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsx🧬 Code graph analysis (4)
apps/web/app/(landing)/welcome-upgrade/page.tsx (1)
apps/web/components/PersonWithLogo.tsx (1)
ABTestimonial(31-39)apps/web/app/(landing)/page.tsx (7)
apps/web/app/(landing)/home/Hero.tsx (1)
HeroHome(29-32)apps/web/app/(landing)/home/Features.tsx (1)
FeaturesHome(20-30)apps/web/app/(landing)/home/Testimonials.tsx (1)
Testimonials(150-173)apps/web/app/(app)/premium/PricingLazy.tsx (1)
PricingLazy(8-12)apps/web/app/(landing)/home/Privacy.tsx (1)
Privacy(3-48)apps/web/app/(landing)/home/FAQs.tsx (1)
FAQs(74-100)apps/web/app/(landing)/home/CTA.tsx (1)
CTA(3-46)apps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsx (1)
apps/web/utils/delayed-actions.ts (1)
canActionBeDelayed(14-16)apps/web/app/(app)/premium/Pricing.tsx (2)
apps/web/app/(app)/premium/config.ts (1)
tiers(242-242)apps/web/utils/index.ts (1)
cn(4-6)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Jit Security
🔇 Additional comments (10)
version.txt (2)
1-1: LGTM — version bump recorded.
No issues with the file format.
1-1: Confirm patch vs. minor and repo-wide consistency.
- Findings: version.txt = v2.9.14; no v2.9.13 occurrences; v2.9.14 appears only in version.txt. No CHANGELOG* files found. apps/* and packages/* package.json files use independent versions; root package.json lacks a version. .github/workflows/build_and_publish_docker.yml reads/writes version.txt and will tag/update it in CI.
- Action required: Confirm this is intended as a patch. If it should be a minor bump, update version.txt to the correct minor version, add/update a CHANGELOG entry, and update any package manifests that must track the repo version. If patch is correct, add a CHANGELOG entry and verify the CI tagging step behaves as expected.
apps/web/app/(marketing) (1)
1-1: Submodule bump only — CI must fetch submodules & confirm marketing presenceCI findings: some workflows use actions/checkout without submodules:true or set fetch-depth: 1; only build_and_publish_docker.yml contains fetch-depth: 0. No .gitmodules found.
Action items:
- Add with: { submodules: true, fetch-depth: 0 } to any checkout steps that need the marketing submodule. Files to update: .github/workflows/claude-code-review.yml (fetch-depth: 1), .github/workflows/claude.yml (fetch-depth: 1), .github/workflows/test.yml (checkout present), and ensure all checkout steps in .github/workflows/build_and_publish_docker.yml are consistent (one step already has fetch-depth: 0).
- Confirm the marketing submodule actually exists (add .gitmodules if needed) and that CI will have access to it.
- Verify the marketing code does not import next/document outside pages/_document.* (search the marketing subtree for "next/document").
apps/web/app/(app)/[emailAccountId]/onboarding/OnboardingCategories.tsx (1)
259-261: Delayed actions now visible — verify backend accepts these valuesLooks good surfacing “after a week” options. Please confirm
createRulesOnboardingActionand the server-side validation/schema acceptmove_folder_delayed(MS) andlabel_archive_delayed(Google) and translate them into scheduled delays consistently.Also applies to: 270-272
apps/web/app/(landing)/welcome-redirect/page.tsx (1)
26-26: Switch to fixed onboarding redirect — confirm query handlingRedirecting unconditionally to
/onboardingis fine. Ifquestionwas previously consumed, confirm that dropping it is intentional or forward it (e.g.,/onboarding?question=...) if still needed.apps/web/app/(app)/[emailAccountId]/assistant/RuleForm.tsx (1)
1060-1062: LGTM: feature-flag dependency removed cleanlyUsing only
canActionBeDelayed(action.type)with[action.type]deps is correct and simplifies the UI gating.apps/web/app/(app)/[emailAccountId]/assistant/onboarding/CategoriesSetup.tsx (1)
234-236: LGTM: unconditional delayed options + mappingAlways showing delayed options is consistent. The
normalizeActionmapping (Google → Microsoft variants) covers the cross-provider case.Also applies to: 244-246
apps/web/app/(landing)/page.tsx (1)
4-9: PricingLazy supports className; no change needed.
apps/web/app/(app)/premium/Pricing.tsx exports PricingProps withclassName?: stringand PricingLazy (apps/web/app/(app)/premium/PricingLazy.tsx) forwards props to the PricingComponent.apps/web/components/PersonWithLogo.tsx (1)
1-39: LGTM: reusable testimonial avatar componentSolid, accessible usage of
next/imagewith fixed dimensions and clear props.apps/web/app/(app)/premium/config.ts (1)
139-155: LGTM: clearer tier positioning and feature phrasingUpdated descriptions and feature list read well and match the new pricing narrative.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| { text: "Process unlimited emails per month" }, | ||
| { | ||
| text: "Unlimited Knowledge Base", | ||
| text: "Everything in Individual, plus:", |
There was a problem hiding this comment.
Avoid hardcoding the other tier’s name; reference the existing businessTierName constant to prevent drift.
Prompt for AI agents
Address the following comment on apps/web/app/(app)/premium/config.ts at line 181:
<comment>Avoid hardcoding the other tier’s name; reference the existing businessTierName constant to prevent drift.</comment>
<file context>
@@ -228,18 +177,15 @@ const businessPlusTier: Tier = {
- { text: "Process unlimited emails per month" },
{
- text: "Unlimited Knowledge Base",
+ text: "Everything in Individual, plus:",
+ },
+ {
</file context>
| text: "Everything in Individual, plus:", | |
| text: `Everything in ${businessTierName}, plus:`, |
1 participant
Summary by CodeRabbit