Conversation
WalkthroughIntroduces a client-side ContentLayout that orders landing sections based on a new feature flag hook. Updates the home page to use ContentLayout. Revises Privacy copy. Adds useHomeLayoutVariant and a HomeLayoutVariant type. Updates a marketing submodule pointer, bumps version to v2.9.3, and switches pre-commit from format to fix. Changes
Sequence Diagram(s)sequenceDiagram
participant U as Browser
participant P as Next.js Home Page
participant C as ContentLayout (client)
participant F as useHomeLayoutVariant
participant FF as Feature Flag Store
U->>P: Request /
P->>C: Render ContentLayout
activate C
C->>F: Get home-layout variant
F->>FF: Read "home-layout"
FF-->>F: "control" | "new" | undefined
F-->>C: Variant (default "control" if undefined)
alt Variant == "new"
C->>C: Render FeaturesHome → Testimonials → PricingLazy → Privacy → FAQs → CTA
else Variant == "control"
C->>C: Render Testimonials → FeaturesHome → Privacy → PricingLazy → FAQs → CTA
end
deactivate C
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle.
Your free Bugbot reviews will reset on October 31
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, please upgrade to Bugbot Pro by visiting the Cursor dashboard. Your first 14 days will be free!
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
apps/web/app/(landing)/home/Privacy.tsx (2)
12-13: Fix Next/Image prop types: width/height must be numbers, not stringsPassing strings can break type safety and may warn in strict TS.
- width="200" - height="120" + width={200} + height={120} @@ - width="300" - height="160" + width={300} + height={160}Also applies to: 21-22
5-5: Section id mismatch: this is Privacy but id is "features"This can break anchor navigation, especially now that section order changes via the layout variant.
- <div className="bg-white py-24" id="features"> + <div className="bg-white py-24" id="privacy">
🧹 Nitpick comments (3)
apps/web/app/(landing)/home/Privacy.tsx (1)
16-22: Avoid duplicate alt text; mark the second badge decorative or differentiateTwo images with identical alt text are redundant for screen readers. Either make one decorative or give distinct, meaningful alt.
<Image src="/images/home/soc2.png" - alt="SOC2 Type II Compliant" + alt="" + aria-hidden="true" className="h-[160px] w-auto" width={300} height={160} />apps/web/hooks/useFeatureFlags.ts (1)
75-79: Avoid unsafe cast; gate variant to the allowed unionPrevents accidental runtime values outside the union from leaking through.
-export function useHomeLayoutVariant() { - return ( - (useFeatureFlagVariantKey("home-layout") as HomeLayoutVariant) || "control" - ); -} +export function useHomeLayoutVariant(): HomeLayoutVariant { + const v = useFeatureFlagVariantKey("home-layout"); + return v === "new" || v === "control" ? v : "control"; +}apps/web/app/(landing)/home/ContentLayout.tsx (1)
14-25: Minor: potential layout shift while PostHog initializesDefaulting to "control" may reorder sections to "new" after flags load. If this is noticeable, consider stabilizing order until the variant is known (cookie, query param, or deferred render).
Also applies to: 27-36
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.husky/pre-commit(1 hunks)apps/web/app/(landing)/home/ContentLayout.tsx(1 hunks)apps/web/app/(landing)/home/Privacy.tsx(1 hunks)apps/web/app/(landing)/page.tsx(1 hunks)apps/web/app/(marketing)(1 hunks)apps/web/hooks/useFeatureFlags.ts(1 hunks)version.txt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (17)
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsxapps/web/hooks/useFeatureFlags.ts
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsxapps/web/app/(marketing)
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsx
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsxapps/web/app/(marketing)version.txtapps/web/hooks/useFeatureFlags.ts.husky/pre-commit
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsxapps/web/hooks/useFeatureFlags.ts
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsxapps/web/hooks/useFeatureFlags.ts
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsxapps/web/app/(marketing)version.txtapps/web/hooks/useFeatureFlags.ts.husky/pre-commit
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(landing)/home/ContentLayout.tsxapps/web/app/(landing)/page.tsxapps/web/app/(landing)/home/Privacy.tsxapps/web/hooks/**/*.ts
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Use SWR for efficient data fetching and caching
apps/web/hooks/**/*.ts: Use SWR for client-side data fetching and caching.
Callmutate()after successful mutations to refresh SWR data on the client.Files:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Call
mutate()after successful mutations to refresh dataFiles:
apps/web/hooks/useFeatureFlags.ts**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.ts: The same validation should be done in the server action too
Define validation schemas using ZodFiles:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/hooks.mdc)
Place custom hooks in the
apps/web/hooks/directory.Files:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/use*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/hooks.mdc)
apps/web/hooks/use*.{js,jsx,ts,tsx}: Name custom hooks with theuseprefix (e.g.,useAccounts.ts).
For fetching data from API endpoints in custom hooks, prefer usinguseSWR.
Create dedicated hooks for specific data types (e.g.,useAccounts,useLabels).
Custom hooks should encapsulate reusable stateful logic, especially for data fetching or complex UI interactions.
Keep custom hooks focused on a single responsibility.Files:
apps/web/hooks/useFeatureFlags.tsapps/web/hooks/useFeatureFlags.ts
📄 CodeRabbit inference engine (.cursor/rules/posthog-feature-flags.mdc)
apps/web/hooks/useFeatureFlags.ts: All feature flag hooks should be defined in apps/web/hooks/useFeatureFlags.ts
Use kebab-case for feature flag keys (e.g., 'inbox-cleaner', 'pricing-options-2')
Use 'use[FeatureName]Enabled' for boolean flag hook names and 'use[FeatureName]Variant' for variant flag hook names
Always define types for variant flags
Always provide a default/control fallback for variant flags
Keep all feature flag hooks centralized in useFeatureFlags.tsFiles:
apps/web/hooks/useFeatureFlags.ts🧠 Learnings (9)
📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR PR: elie222/inbox-zero#0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/**/*.tsx : Use LoadingContent component for async dataApplied to files:
apps/web/app/(landing)/home/ContentLayout.tsx📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR PR: elie222/inbox-zero#0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/**/*.tsx : Use `LoadingContent` component to handle loading and error states consistentlyApplied to files:
apps/web/app/(landing)/home/ContentLayout.tsx📚 Learning: 2025-07-18T15:05:16.146Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/fullstack-workflow.mdc:0-0 Timestamp: 2025-07-18T15:05:16.146Z Learning: Applies to apps/web/components/**/*.tsx : Use the `LoadingContent` component to handle loading and error states consistently in data-fetching components.Applied to files:
apps/web/app/(landing)/home/ContentLayout.tsx📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Use 'use[FeatureName]Enabled' for boolean flag hook names and 'use[FeatureName]Variant' for variant flag hook namesApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Always define types for variant flagsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Keep all feature flag hooks centralized in useFeatureFlags.tsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : All feature flag hooks should be defined in apps/web/hooks/useFeatureFlags.tsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Always provide a default/control fallback for variant flagsApplied to files:
apps/web/hooks/useFeatureFlags.ts📚 Learning: 2025-07-18T15:07:12.415Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/posthog-feature-flags.mdc:0-0 Timestamp: 2025-07-18T15:07:12.415Z Learning: Applies to apps/web/hooks/useFeatureFlags.ts : Use kebab-case for feature flag keys (e.g., 'inbox-cleaner', 'pricing-options-2')Applied to files:
apps/web/hooks/useFeatureFlags.ts🧬 Code graph analysis (1)
apps/web/app/(landing)/page.tsx (1)
apps/web/app/(landing)/home/Hero.tsx (1)
HeroHome(29-32)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Secret Detection
- GitHub Check: Jit Security
🔇 Additional comments (8)
version.txt (2)
1-1: Patch version bump to v2.9.3 — LGTM.No issues with the version file update.
1-1: Repo consistency check passed: no stale version refs or submodule/tooling misalignments detected.apps/web/app/(marketing) (1)
1-1: apps/web/app/(marketing) isn’t a Git submodule—original submodule-pointer verification request is not applicableLikely an incorrect or invalid review comment.
.husky/pre-commit (1)
4-4: No action needed:npx ultracite fixsubcommand is available
Verified vianpx ultracite --helpthatfixis listed as a valid subcommand.apps/web/app/(landing)/home/Privacy.tsx (1)
32-43: Copy changes LGTMUpdated privacy messaging reads clearly and aligns with the product positioning.
apps/web/app/(landing)/page.tsx (1)
12-13: LGTM: Landing content consolidated via ContentLayoutComposition is clear and keeps the server-page + client-content boundary correct.
apps/web/hooks/useFeatureFlags.ts (1)
73-74: Flag naming and defaulting are consistent with guidelinesKebab-case key and
use[Feature]Variantnaming look good.apps/web/app/(landing)/home/ContentLayout.tsx (1)
6-7: Ensure PricingLazy is a Client Component & supports className
PricingLazy.tsx currently has no"use client"directive and may not expose aclassNameprop. Adduse clientat the top of apps/web/app/(app)/premium/PricingLazy.tsx and update its PricingProps (in Pricing.tsx) to includeclassName?: stringso you can forwardclassNamefrom ContentLayout.tsx without errors.
| npx lint-staged | ||
| # pnpm run lint | ||
|
|
||
| npx ultracite format No newline at end of file | ||
| npx ultracite fix No newline at end of file |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Run "fix" before lint-staged to ensure changes are staged and committed
If ultracite fix writes files after lint-staged runs, fixes won't be included in the commit.
- npx lint-staged
- # pnpm run lint
-
- npx ultracite fix
+ npx ultracite fix
+ # pnpm run lint
+
+ npx lint-staged📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| npx lint-staged | |
| # pnpm run lint | |
| npx ultracite format | |
| \ No newline at end of file | |
| npx ultracite fix | |
| npx ultracite fix | |
| # pnpm run lint | |
| npx lint-staged |
🤖 Prompt for AI Agents
In .husky/pre-commit around lines 1 to 4, the hook runs lint-staged before
running npx ultracite fix so any files modified by ultracite won't be picked up
by lint-staged; move the npx ultracite fix line to run before npx lint-staged
and ensure any files changed by ultracite are re-staged (git add --all or
equivalent) so lint-staged sees them; leave the commented pnpm run lint line
as-is or adjust ordering consistently.
1 participant
Summary by CodeRabbit