Conversation
WalkthroughAdds a new CrispChatLoggedOutVisible component that configures Crisp on mount and renders null. Integrates it into login and login error pages via React Suspense for lazy loading. Updates login error text. Bumps version from v2.8.12 to v2.8.13. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant LoginPage as Login/Error Page
participant Suspense as React Suspense
participant CrispLite as CrispChatLoggedOutVisible
participant CrispSDK as Crisp SDK
User->>LoginPage: Navigate / render
LoginPage->>Suspense: Render lazy Crisp widget
Suspense->>CrispLite: Mount
Note right of CrispLite: On mount, check env.NEXT_PUBLIC_CRISP_WEBSITE_ID
alt ID present
CrispLite->>CrispSDK: configure(websiteId)
else No ID
CrispLite--xCrispSDK: skip configure
end
CrispLite-->>LoginPage: render null
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
apps/web/app/(landing)/login/page.tsx (2)
11-11: Use next/dynamic so Suspense actually lazy-loads CrispSuspense alone won’t defer loading here; the static import eagerly includes the component. Switch to a dynamic import with
ssr: falseto truly lazy-load and keep the page lighter.+import dynamic from "next/dynamic"; -import { CrispChatLoggedOutVisible } from "@/components/CrispChat"; +const CrispChatLoggedOutVisible = dynamic( + () => + import("@/components/CrispChat").then((m) => m.CrispChatLoggedOutVisible), + { ssr: false } +);
104-113: Tweak error copy (grammar and punctuation)Minor polish for clarity and tone.
- <AlertBasic + <AlertBasic variant="destructive" title="Error logging in" - description={`There was an error logging in. Please try log in again. If this error persists please contact support at ${env.NEXT_PUBLIC_SUPPORT_EMAIL}`} + description={`There was an error logging in. Please try logging in again. If this error persists, contact support at ${env.NEXT_PUBLIC_SUPPORT_EMAIL}.`} />apps/web/app/(landing)/login/error/page.tsx (1)
5-5: Also dynamic-import Crisp on the error pageSame as login: use
next/dynamicso the Crisp bundle isn’t eagerly loaded.-import { Suspense, useEffect } from "react"; +import { Suspense, useEffect } from "react"; +import dynamic from "next/dynamic"; @@ -import { CrispChatLoggedOutVisible } from "@/components/CrispChat"; +const CrispChatLoggedOutVisible = dynamic( + () => + import("@/components/CrispChat").then((m) => m.CrispChatLoggedOutVisible), + { ssr: false } +);Also applies to: 14-15, 47-49
apps/web/components/CrispChat.tsx (2)
15-21: Optional: de-duplicate configure across componentsBoth components call
Crisp.configure(...). Guard configuration once per session to avoid redundant calls during route transitions.Add near the top of this module:
let crispConfigured = false; const ensureCrispConfigured = () => { if (crispConfigured || !env.NEXT_PUBLIC_CRISP_WEBSITE_ID) return false; Crisp.configure(env.NEXT_PUBLIC_CRISP_WEBSITE_ID); crispConfigured = true; return true; };Then replace direct
Crisp.configure(...)calls withensureCrispConfigured(). KeepCrisp.setHideOnMobile(true)in the logged-inCrispChateffect only.
44-52: Consider clearing prior user context on logged-out flowsIf a user hits the login error after being logged in, Crisp may retain their email/metadata. Clearing the session avoids leaking prior user info to support.
You can add this before opening the chat (verify with Crisp docs):
// Clear any previous user context before showing chat to a logged-out user try { // Crisp queues commands; this is safe post-config // Option A (preferred, if supported): // Crisp.session.reset(true); // Option B (fallback): clear fields individually // Crisp.user.setEmail(""); } catch {}Would you like me to confirm the recommended reset method in the latest Crisp Web SDK docs?
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
apps/web/app/(landing)/login/error/page.tsx(4 hunks)apps/web/app/(landing)/login/page.tsx(2 hunks)apps/web/components/CrispChat.tsx(1 hunks)version.txt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/components/CrispChat.tsxapps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/components/CrispChat.tsxapps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsx
apps/web/components/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Use React Hook Form with Zod validation for form handling
Use the
LoadingContentcomponent to handle loading and error states consistently in data-fetching components.Use PascalCase for components (e.g.
components/Button.tsx)
Files:
apps/web/components/CrispChat.tsx
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
apps/web/components/CrispChat.tsxversion.txtapps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/components/CrispChat.tsxapps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/components/CrispChat.tsxapps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/components/CrispChat.tsxapps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsx
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
apps/web/components/CrispChat.tsxversion.txtapps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/components/CrispChat.tsxapps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/components/CrispChat.tsxapps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsxapps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsxapps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirectiveFiles:
apps/web/app/(landing)/login/error/page.tsxapps/web/app/(landing)/login/page.tsx🧠 Learnings (7)
📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR PR: elie222/inbox-zero#0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/**/*.tsx : Use `LoadingContent` component to handle loading and error states consistentlyApplied to files:
apps/web/app/(landing)/login/error/page.tsx📚 Learning: 2025-07-18T15:05:16.146Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/fullstack-workflow.mdc:0-0 Timestamp: 2025-07-18T15:05:16.146Z Learning: Applies to apps/web/components/**/*.tsx : Use the `LoadingContent` component to handle loading and error states consistently in data-fetching components.Applied to files:
apps/web/app/(landing)/login/error/page.tsx📚 Learning: 2025-06-05T09:49:12.168Z
Learnt from: elie222 PR: elie222/inbox-zero#485 File: apps/web/app/(landing)/login/page.tsx:41-43 Timestamp: 2025-06-05T09:49:12.168Z Learning: In Next.js App Router, components that use the `useSearchParams` hook require a Suspense boundary to handle the asynchronous nature of search parameter access. The Suspense wrapper is necessary and should not be removed when a component uses useSearchParams.Applied to files:
apps/web/app/(landing)/login/error/page.tsx📚 Learning: 2025-07-19T17:50:22.078Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/ui-components.mdc:0-0 Timestamp: 2025-07-19T17:50:22.078Z Learning: Applies to components/**/*.tsx : Use the `LoadingContent` component to handle loading statesApplied to files:
apps/web/app/(landing)/login/error/page.tsx📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR PR: elie222/inbox-zero#0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/**/*.tsx : Use LoadingContent component for async dataApplied to files:
apps/web/app/(landing)/login/error/page.tsx📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR PR: elie222/inbox-zero#0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/**/*.tsx : Pass `loading`, `error`, and children props to `LoadingContent`Applied to files:
apps/web/app/(landing)/login/error/page.tsx📚 Learning: 2025-07-08T13:14:07.449Z
Learnt from: elie222 PR: elie222/inbox-zero#537 File: apps/web/app/(app)/[emailAccountId]/clean/onboarding/page.tsx:30-34 Timestamp: 2025-07-08T13:14:07.449Z Learning: The clean onboarding page in apps/web/app/(app)/[emailAccountId]/clean/onboarding/page.tsx is intentionally Gmail-specific and should show an error for non-Google email accounts rather than attempting to support multiple providers.Applied to files:
apps/web/app/(landing)/login/error/page.tsx🧬 Code graph analysis (3)
apps/web/components/CrispChat.tsx (1)
apps/web/env.ts (1)
env(16-232)apps/web/app/(landing)/login/error/page.tsx (2)
apps/web/env.ts (1)
env(16-232)apps/web/components/CrispChat.tsx (1)
CrispChatLoggedOutVisible(45-52)apps/web/app/(landing)/login/page.tsx (2)
apps/web/env.ts (1)
env(16-232)apps/web/components/CrispChat.tsx (1)
CrispChatLoggedOutVisible(45-52)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Cursor Bugbot
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
version.txt (1)
1-1: Version bump looks goodNo issues with the metadata change to v2.8.13.
| // This is used to show the Crisp chat when the user is logged out, and auto opens to help the user | ||
| export const CrispChatLoggedOutVisible = () => { | ||
| useEffect(() => { | ||
| if (!env.NEXT_PUBLIC_CRISP_WEBSITE_ID) return; | ||
| Crisp.configure(env.NEXT_PUBLIC_CRISP_WEBSITE_ID); | ||
| }, []); | ||
|
|
||
| return null; | ||
| }; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Match the intent: auto-open the chat for logged-out users
The comment says “auto opens,” but the effect only configures Crisp. Open and show the widget so users immediately see support.
export const CrispChatLoggedOutVisible = () => {
useEffect(() => {
if (!env.NEXT_PUBLIC_CRISP_WEBSITE_ID) return;
- Crisp.configure(env.NEXT_PUBLIC_CRISP_WEBSITE_ID);
+ Crisp.configure(env.NEXT_PUBLIC_CRISP_WEBSITE_ID);
+ // Ensure visibility and open the widget to assist the user
+ Crisp.chat.show();
+ Crisp.chat.open();
}, []);
return null;
};📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // This is used to show the Crisp chat when the user is logged out, and auto opens to help the user | |
| export const CrispChatLoggedOutVisible = () => { | |
| useEffect(() => { | |
| if (!env.NEXT_PUBLIC_CRISP_WEBSITE_ID) return; | |
| Crisp.configure(env.NEXT_PUBLIC_CRISP_WEBSITE_ID); | |
| }, []); | |
| return null; | |
| }; | |
| // This is used to show the Crisp chat when the user is logged out, and auto opens to help the user | |
| export const CrispChatLoggedOutVisible = () => { | |
| useEffect(() => { | |
| if (!env.NEXT_PUBLIC_CRISP_WEBSITE_ID) return; | |
| Crisp.configure(env.NEXT_PUBLIC_CRISP_WEBSITE_ID); | |
| // Ensure visibility and open the widget to assist the user | |
| Crisp.chat.show(); | |
| Crisp.chat.open(); | |
| }, []); | |
| return null; | |
| }; |
🤖 Prompt for AI Agents
In apps/web/components/CrispChat.tsx around lines 44 to 52, the effect only
configures Crisp but does not actually open the chat as the comment promises;
modify the effect so that after calling
Crisp.configure(env.NEXT_PUBLIC_CRISP_WEBSITE_ID) you immediately open/show the
widget (for example call the SDK method that displays the chat such as
Crisp.show() or push window.$crisp with ["do", "chat:show"] depending on the
Crisp integration used), keeping the env guard and empty deps array intact.
1 participant
Summary by CodeRabbit