Conversation
WalkthroughCrispChat integration moved from AppLayout to SideNavWithTopNav with dynamic, client-only loading. CrispChat now uses sidebar UI state and account email, not route path or props. Minor spacing tweak in RulesTabNew. Version bumped to v2.6.13. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as SideNavWithTopNav
participant Susp as Suspense Boundary
participant CC as CrispChat (dynamic, no SSR)
participant Crisp as Crisp SDK
participant Auth as useAccount
participant Sidebar as useSidebar
User->>UI: Navigate / toggle chat sidebar
UI->>Susp: Render
Susp-->>CC: Dynamically load CrispChat
CC->>Auth: Read userEmail
Auth-->>CC: userEmail
CC->>Crisp: configure() + setHideOnMobile()
CC->>Sidebar: Read state (includes "chat-sidebar")
alt chat-sidebar open
CC->>Crisp: chat.show()
else closed
CC->>Crisp: chat.hide()
end
CC->>Crisp: user.setEmail(userEmail) (when configured)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsx (1)
11-29: If Tabs uses useSearchParams under the hood, wrap in SuspensePer past learnings, components reading search params should be within a Suspense boundary. If your Tabs implementation reads useSearchParams when searchParam is provided, add a Suspense wrapper.
Apply if applicable:
+import { Suspense } from "react"; @@ - <Tabs defaultValue="list" searchParam="format"> + <Suspense fallback={null}> + <Tabs defaultValue="list" searchParam="format"> @@ - </Tabs> + </Tabs> + </Suspense>apps/web/components/CrispChat.tsx (1)
10-14: Nit: clarify naming to avoid confusionisChatOpen refers to the app’s sidebar state, not the Crisp widget. Rename for clarity.
Apply:
- const isChatOpen = state.includes("chat-sidebar"); + const isRightSidebarOpen = state.includes("chat-sidebar"); @@ - if (isChatOpen) { + if (isRightSidebarOpen) { @@ - }, [isConfigured, isChatOpen]); + }, [isConfigured, isRightSidebarOpen]);Also applies to: 34-39
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsx(1 hunks)apps/web/app/(app)/layout.tsx(0 hunks)apps/web/components/CrispChat.tsx(2 hunks)apps/web/components/SideNavWithTopNav.tsx(3 hunks)version.txt(1 hunks)
💤 Files with no reviewable changes (1)
- apps/web/app/(app)/layout.tsx
🧰 Additional context used
📓 Path-based instructions (15)
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsxapps/web/components/SideNavWithTopNav.tsxapps/web/components/CrispChat.tsx
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsxapps/web/components/SideNavWithTopNav.tsxapps/web/components/CrispChat.tsx
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsxapps/web/components/SideNavWithTopNav.tsxversion.txtapps/web/components/CrispChat.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsxapps/web/components/SideNavWithTopNav.tsxapps/web/components/CrispChat.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsxapps/web/components/SideNavWithTopNav.tsxapps/web/components/CrispChat.tsx
apps/web/app/(app)/*/**
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsx
apps/web/app/(app)/*/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If you need to use onClick in a component, that component is a client component and file must start with 'use client'
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsx
apps/web/app/(app)/*/**/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If we're in a deeply nested component we will use swr to fetch via API
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsx
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsxapps/web/components/SideNavWithTopNav.tsxapps/web/components/CrispChat.tsx
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsxapps/web/components/SideNavWithTopNav.tsxversion.txtapps/web/components/CrispChat.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsxapps/web/components/SideNavWithTopNav.tsxapps/web/components/CrispChat.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsxapps/web/components/SideNavWithTopNav.tsxapps/web/components/CrispChat.tsxapps/web/components/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Use React Hook Form with Zod validation for form handling
Use the
LoadingContentcomponent to handle loading and error states consistently in data-fetching components.Use PascalCase for components (e.g.
components/Button.tsx)Files:
apps/web/components/SideNavWithTopNav.tsxapps/web/components/CrispChat.tsx🧠 Learnings (1)
📚 Learning: 2025-06-05T09:49:12.168Z
Learnt from: elie222 PR: elie222/inbox-zero#485 File: apps/web/app/(landing)/login/page.tsx:41-43 Timestamp: 2025-06-05T09:49:12.168Z Learning: In Next.js App Router, components that use the `useSearchParams` hook require a Suspense boundary to handle the asynchronous nature of search parameter access. The Suspense wrapper is necessary and should not be removed when a component uses useSearchParams.Applied to files:
apps/web/components/SideNavWithTopNav.tsx🧬 Code graph analysis (1)
apps/web/components/CrispChat.tsx (2)
apps/web/providers/EmailAccountProvider.tsx (1)
useAccount(72-82)apps/web/env.ts (1)
env(16-225)🔇 Additional comments (5)
version.txt (1)
1-1: Version bump looks goodVersion updated to v2.6.13. No issues.
apps/web/app/(app)/[emailAccountId]/assistant/RulesTabNew.tsx (1)
8-8: Minor spacing tweak is fineAdding mt-8 is safe and keeps layout concerns localized.
apps/web/components/SideNavWithTopNav.tsx (1)
63-71: Crisp placement under SidebarProvider is correctMounting Crisp inside ContentWrapper keeps it within the sidebar state context and out of the onboarding route. Good move.
apps/web/components/CrispChat.tsx (2)
34-39: Confirm intended show/hide logicCurrent logic hides Crisp when the app’s chat sidebar is open and shows it otherwise. Confirm this is desired to avoid overlapping chat UIs.
23-24: Script to locateAppProvidershas been run; awaiting results.
| const CrispWithNoSSR = dynamic(() => import("@/components/CrispChat")); | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Make the dynamic import truly client-only and Suspense-aware
Without options, dynamic can attempt SSR and your Suspense wrapper won’t take effect. Enable no-SSR and Suspense.
Apply:
-const CrispWithNoSSR = dynamic(() => import("@/components/CrispChat"));
+const CrispWithNoSSR = dynamic(() => import("@/components/CrispChat"), {
+ ssr: false,
+ suspense: true,
+});📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const CrispWithNoSSR = dynamic(() => import("@/components/CrispChat")); | |
| const CrispWithNoSSR = dynamic(() => import("@/components/CrispChat"), { | |
| ssr: false, | |
| suspense: true, | |
| }); |
🤖 Prompt for AI Agents
In apps/web/components/SideNavWithTopNav.tsx around lines 17 to 18, the dynamic
import for CrispChat is currently created without options so it may be
server-rendered and bypass your Suspense wrapper; update the dynamic call to be
client-only and Suspense-aware by enabling ssr: false and suspense: true in the
dynamic options so the component is only loaded on the client and works with
your Suspense fallback.
| <Suspense> | ||
| <CrispWithNoSSR /> | ||
| </Suspense> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Provide a Suspense fallback
React’s Suspense expects a fallback; also now that dynamic uses suspense: true, this will render correctly.
Apply:
- <Suspense>
- <CrispWithNoSSR />
- </Suspense>
+ <Suspense fallback={null}>
+ <CrispWithNoSSR />
+ </Suspense>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <Suspense> | |
| <CrispWithNoSSR /> | |
| </Suspense> | |
| <Suspense fallback={null}> | |
| <CrispWithNoSSR /> | |
| </Suspense> |
🤖 Prompt for AI Agents
In apps/web/components/SideNavWithTopNav.tsx around lines 40 to 42, the Suspense
wrapper lacks a fallback prop which React requires (especially since the
component is rendered with suspense: true). Wrap <CrispWithNoSSR /> in Suspense
providing a meaningful fallback (e.g., a small loader, skeleton, or null) by
adding the fallback attribute to the Suspense element so the UI shows during
async loading.
1 participant
Summary by CodeRabbit
Refactor
Style
Chores