Conversation
|
Caution Review failedThe pull request is closed. WalkthroughUpdates change UTM handling to pass a cookie store into fetchUserAndStoreUtms and store UTMs using the provided cookies; adds a new NEXT_PUBLIC_LOG_SCOPES env var and scope-filtering/no-op logger behavior; increments version from v2.8.7 to v2.8.8. Changes
Sequence Diagram(s)sequenceDiagram
participant Browser
participant Page
participant UTMsModule
participant DB
Note over Page: Page obtains cookieStore via next/headers.cookies()
Browser->>Page: load page / onboarding or welcome
Page->>Page: await cookies() -> cookieStore
Page->>UTMsModule: fetchUserAndStoreUtms(userId, cookieStore)
UTMsModule->>UTMsModule: read utm values from cookieStore (cookies.get)
UTMsModule->>DB: prisma.update(...) to store UTMs
alt success
UTMsModule-->>Page: log success
else error
UTMsModule-->>Page: log error
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
apps/web/env.ts (1)
1-232: Add NEXT_PUBLIC_LOG_SCOPES to ecosystem files
• apps/web/.env.example: declare NEXT_PUBLIC_LOG_SCOPES with a sample value
• turbo.json (root): add NEXT_PUBLIC_LOG_SCOPES undertasks.build.envto include it in buildsapps/web/app/(landing)/welcome/utms.tsx (1)
30-42: Coalesce cookie values to null to avoid undefined in JSON payloads
undefinedis not valid in JSON and can cause Prisma JSON writes to error. Also simplify by extracting.valueonce.Apply:
- const utmCampaign = cookies.get("utm_campaign"); - const utmMedium = cookies.get("utm_medium"); - const utmSource = cookies.get("utm_source"); - const utmTerm = cookies.get("utm_term"); - const affiliate = cookies.get("affiliate"); + const utmCampaign = cookies.get("utm_campaign")?.value ?? null; + const utmMedium = cookies.get("utm_medium")?.value ?? null; + const utmSource = cookies.get("utm_source")?.value ?? null; + const utmTerm = cookies.get("utm_term")?.value ?? null; + const affiliate = cookies.get("affiliate")?.value ?? null; - const utms = { - utmCampaign: utmCampaign?.value, - utmMedium: utmMedium?.value, - utmSource: utmSource?.value, - utmTerm: utmTerm?.value, - affiliate: affiliate?.value, - }; + const utms = { utmCampaign, utmMedium, utmSource, utmTerm, affiliate };Optional guard to skip no-op writes:
+ if (Object.values(utms).every((v) => v == null || v === "")) { + logger.info("No UTM cookies present; skipping update", { userId }); + return; + }
🧹 Nitpick comments (9)
apps/web/utils/logger.ts (2)
17-21: Scope-gated logging: confirm scope value normalizationThe includes() check is strict; if env scopes contain whitespace/case variations, matches can silently fail. See my env.ts comment to trim items on split to avoid surprises.
89-97: Align null logger method signatures to the public logger shapeAvoid subtle typing/IDE friction by matching parameter lists.
Apply this diff:
-function createNullLogger() { - return { - info: () => {}, - error: () => {}, - warn: () => {}, - trace: () => {}, - with: () => createNullLogger(), - }; -} +function createNullLogger() { + const noop = (_message?: string, ..._args: unknown[]) => {}; + return { + info: noop, + error: noop, + warn: noop, + trace: noop, + with: (_newFields: Record<string, unknown>) => createNullLogger(), + }; +}apps/web/env.ts (1)
167-170: Trim and filter scopes when splitting the env varPrevents mismatches from "scope-a, scope-b" or trailing commas.
Apply this diff:
- NEXT_PUBLIC_LOG_SCOPES: z - .string() - .optional() - .transform((value) => value?.split(",")), + NEXT_PUBLIC_LOG_SCOPES: z + .string() + .optional() + .transform((value) => + value?.split(",").map((s) => s.trim()).filter(Boolean), + ),apps/web/app/(app)/[emailAccountId]/onboarding/page.tsx (2)
21-22: Handle NaN safely when parsing stepIf step is present but invalid, you’ll get NaN. Provide a fallback.
Apply this diff:
- const step = searchParams.step ? Number.parseInt(searchParams.step, 10) : 1; + const parsed = searchParams.step ? Number.parseInt(searchParams.step, 10) : 1; + const step = Number.isNaN(parsed) ? 1 : parsed;
25-25: cookies() is synchronous; drop the unnecessary awaitKeeps intent clear.
Apply this diff:
- const cookieStore = await cookies(); + const cookieStore = cookies();apps/web/app/(landing)/welcome/page.tsx (2)
23-26: Specify radix and guard against NaN for question parsingAdds determinism and avoids NaN.
Apply this diff:
- const questionIndex = searchParams.question - ? Number.parseInt(searchParams.question) - : 0; + const qParsed = searchParams.question + ? Number.parseInt(searchParams.question, 10) + : 0; + const questionIndex = Number.isNaN(qParsed) ? 0 : qParsed;
29-29: cookies() is synchronous; remove awaitMinor clarity tweak.
Apply this diff:
- const cookieStore = await cookies(); + const cookieStore = cookies();apps/web/app/(landing)/welcome/utms.tsx (2)
3-3: Avoid deep Next.js type import; use ReturnType insteadThe path
next/dist/server/...is an internal deep import and brittle across Next upgrades. Use the publicnext/headersAPI for typing via a type query.Apply:
-import type { ReadonlyRequestCookies } from "next/dist/server/web/spec-extension/adapters/request-cookies"; +type CookieStore = ReturnType<typeof import("next/headers").cookies>;
26-27: Function-local scoped logger can reduce noiseOptional: inside this function, derive a scoped logger with
userIdto avoid passing it each call, e.g.,const log = logger.with({ userId }), then uselog.info/error(...).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
apps/web/app/(app)/[emailAccountId]/onboarding/page.tsx(2 hunks)apps/web/app/(landing)/welcome/page.tsx(2 hunks)apps/web/app/(landing)/welcome/utms.tsx(3 hunks)apps/web/env.ts(2 hunks)apps/web/utils/logger.ts(2 hunks)version.txt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (20)
!{.cursor/rules/*.mdc}
📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)
Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location
Files:
version.txtapps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/env.tsapps/web/utils/logger.tsapps/web/app/(landing)/welcome/utms.tsx
!pages/_document.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.
Files:
version.txtapps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/env.tsapps/web/utils/logger.tsapps/web/app/(landing)/welcome/utms.tsx
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use@/for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX
Files:
apps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/env.tsapps/web/utils/logger.tsapps/web/app/(landing)/welcome/utms.tsx
apps/web/app/**
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
NextJS app router structure with (app) directory
Files:
apps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/app/(landing)/welcome/utms.tsx
apps/web/**/*.tsx
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Useresult?.serverErrorwithtoastErrorandtoastSuccess
UseLoadingContentcomponent to handle loading and error states consistently
Passloading,error, and children props toLoadingContent
Files:
apps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/app/(landing)/welcome/utms.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields
Files:
apps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/app/(landing)/welcome/utms.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)
**/*.{ts,tsx}: UsecreateScopedLoggerfor logging in backend TypeScript files
Typically add the logger initialization at the top of the file when usingcreateScopedLogger
Only use.with()on a logger instance within a specific function, not for a global loggerImport Prisma in the project using
import prisma from "@/utils/prisma";
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.
Files:
apps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/env.tsapps/web/utils/logger.tsapps/web/app/(landing)/welcome/utms.tsx
apps/web/app/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Components with
onClickmust be client components withuse clientdirective
Files:
apps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/app/(landing)/welcome/utms.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{js,jsx,ts,tsx}: Don't useelements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...
Files:
apps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/env.tsapps/web/utils/logger.tsapps/web/app/(landing)/welcome/utms.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.
Files:
apps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/app/(landing)/welcome/utms.tsx
**/*.{html,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...Files:
apps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/app/(landing)/welcome/utms.tsxapps/web/app/(app)/*/**
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder
Files:
apps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/app/(app)/*/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If you need to use onClick in a component, that component is a client component and file must start with 'use client'
Files:
apps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/app/(app)/*/**/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)
If we're in a deeply nested component we will use swr to fetch via API
Files:
apps/web/app/(app)/[emailAccountId]/onboarding/page.tsxapps/web/**/{.env.example,env.ts,turbo.json}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Add environment variables to
.env.example,env.ts, andturbo.jsonFiles:
apps/web/env.tsapps/web/**/{.env.example,env.ts}
📄 CodeRabbit inference engine (apps/web/CLAUDE.md)
Client-side environment variables: Prefix with
NEXT_PUBLIC_Files:
apps/web/env.tsapps/web/env.ts
📄 CodeRabbit inference engine (.cursor/rules/environment-variables.mdc)
apps/web/env.ts: When adding a new environment variable, add it toapps/web/env.tsin the appropriate section: useserverfor server-only variables, and for client-side variables, use theclientsection and also add toexperimental__runtimeEnv.
Client-side environment variables must be prefixed withNEXT_PUBLIC_and added to both theclientandexperimental__runtimeEnvsections inapps/web/env.ts.Files:
apps/web/env.ts**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)
**/*.ts: The same validation should be done in the server action too
Define validation schemas using ZodFiles:
apps/web/env.tsapps/web/utils/logger.tsapps/web/utils/**
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
Create utility functions in
utils/folder for reusable logicFiles:
apps/web/utils/logger.tsapps/web/utils/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)
apps/web/utils/**/*.ts: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle sizeFiles:
apps/web/utils/logger.ts🧠 Learnings (8)
📚 Learning: 2025-06-05T09:49:12.168Z
Learnt from: elie222 PR: elie222/inbox-zero#485 File: apps/web/app/(landing)/login/page.tsx:41-43 Timestamp: 2025-06-05T09:49:12.168Z Learning: In Next.js App Router, components that use the `useSearchParams` hook require a Suspense boundary to handle the asynchronous nature of search parameter access. The Suspense wrapper is necessary and should not be removed when a component uses useSearchParams.Applied to files:
apps/web/app/(landing)/welcome/page.tsxapps/web/app/(app)/[emailAccountId]/onboarding/page.tsx📚 Learning: 2025-07-18T15:04:50.520Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/environment-variables.mdc:0-0 Timestamp: 2025-07-18T15:04:50.520Z Learning: Applies to apps/web/env.ts : Client-side environment variables must be prefixed with `NEXT_PUBLIC_` and added to both the `client` and `experimental__runtimeEnv` sections in `apps/web/env.ts`.Applied to files:
apps/web/env.ts📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR PR: elie222/inbox-zero#0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/**/{.env.example,env.ts} : Client-side environment variables: Prefix with `NEXT_PUBLIC_`Applied to files:
apps/web/env.ts📚 Learning: 2025-07-18T15:04:50.520Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/environment-variables.mdc:0-0 Timestamp: 2025-07-18T15:04:50.520Z Learning: Applies to apps/web/env.ts : When adding a new environment variable, add it to `apps/web/env.ts` in the appropriate section: use `server` for server-only variables, and for client-side variables, use the `client` section and also add to `experimental__runtimeEnv`.Applied to files:
apps/web/env.ts📚 Learning: 2025-07-18T15:04:30.467Z
Learnt from: CR PR: elie222/inbox-zero#0 File: apps/web/CLAUDE.md:0-0 Timestamp: 2025-07-18T15:04:30.467Z Learning: Applies to apps/web/**/{.env.example,env.ts,turbo.json} : Add environment variables to `.env.example`, `env.ts`, and `turbo.json`Applied to files:
apps/web/env.ts📚 Learning: 2025-08-17T16:57:25.834Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/llm.mdc:0-0 Timestamp: 2025-08-17T16:57:25.834Z Learning: Applies to apps/web/utils/{ai,llms}/**/*.ts : Use descriptive scoped loggers per feature and log inputs/outputs with appropriate levels and contextApplied to files:
apps/web/utils/logger.ts📚 Learning: 2025-07-18T15:06:47.625Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/logging.mdc:0-0 Timestamp: 2025-07-18T15:06:47.625Z Learning: Applies to **/*.{ts,tsx} : Use `createScopedLogger` for logging in backend TypeScript filesApplied to files:
apps/web/utils/logger.ts📚 Learning: 2025-07-18T15:06:47.625Z
Learnt from: CR PR: elie222/inbox-zero#0 File: .cursor/rules/logging.mdc:0-0 Timestamp: 2025-07-18T15:06:47.625Z Learning: Applies to **/*.{ts,tsx} : Typically add the logger initialization at the top of the file when using `createScopedLogger`Applied to files:
apps/web/utils/logger.ts🧬 Code graph analysis (3)
apps/web/app/(landing)/welcome/page.tsx (1)
apps/web/app/(landing)/welcome/utms.tsx (1)
fetchUserAndStoreUtms(7-24)apps/web/app/(app)/[emailAccountId]/onboarding/page.tsx (1)
apps/web/app/(landing)/welcome/utms.tsx (1)
fetchUserAndStoreUtms(7-24)apps/web/utils/logger.ts (1)
apps/web/env.ts (1)
env(16-232)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cursor Bugbot
🔇 Additional comments (5)
version.txt (1)
1-1: Version bump looks goodNo functional impact; aligns with the PR scope.
apps/web/env.ts (1)
225-225: Runtime mapping added correctlyPublic var is exposed via experimental__runtimeEnv as required.
apps/web/app/(app)/[emailAccountId]/onboarding/page.tsx (1)
29-30: UTM capture hook LGTMFetching once via authPromise and passing the cookie snapshot into after() is correct.
apps/web/app/(landing)/welcome/page.tsx (1)
33-34: UTM persistence call LGTMMatches the new signature and captures the request cookie snapshot correctly.
apps/web/app/(landing)/welcome/utms.tsx (1)
22-22: LGTM: defer to storeUtms only when utms absentCall flow is clear and avoids unnecessary writes.
| export async function fetchUserAndStoreUtms( | ||
| userId: string, | ||
| cookies: ReadonlyRequestCookies, | ||
| ) { |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Signature change looks good; ensure all call sites pass the cookie store
New param aligns with app router constraints. If you adopt the type change above, update this annotation to CookieStore.
Run to confirm all usages updated to the 2-arg form:
🏁 Script executed:
#!/bin/bash
rg -nP 'fetchUserAndStoreUtms\s*\(' -C2Length of output: 1173
Update parameter type to CookieStore
All call sites now pass cookieStore. Change the cookies parameter in fetchUserAndStoreUtms from ReadonlyRequestCookies to CookieStore.
🤖 Prompt for AI Agents
In apps/web/app/(landing)/welcome/utms.tsx around lines 7 to 10, the function
parameter type for cookies is declared as ReadonlyRequestCookies but all call
sites now pass cookieStore; change the parameter type to CookieStore, update or
add the appropriate import for CookieStore (from next/headers or your
framework's headers module), and adjust any immediate usages that rely on
ReadonlyRequestCookies APIs to the CookieStore API if there are differences.
1 participant
Summary by CodeRabbit