Fix cold email blocker on previous messages from sender

[elie222]

Summary by CodeRabbit

• New Features

  • Integrated a unique email identifier across email testing, categorization, and cold email blocking processes. This enhancement improves message tracking and overall precision in handling your emails.

• Refactor

  • Streamlined parameter usage and naming conventions to ensure consistent processing and reliable performance across our email operations.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
inbox-zero	🔄 Building (Inspect)	Visit Preview	Feb 9, 2025 1:13pm

[coderabbitai]

Walkthrough

This change set adds a new property, messageId, across multiple modules to enhance email testing, categorization, and cold email detection. The modifications include updating UI event handlers, API functions and validation schemas, as well as utility methods that previously relied on threadId. Additionally, a function renaming (aicategorize → aiCategorize) standardizes the naming convention. The overall adjustments improve the consistency of the email-processing data without altering the core control flows.

Changes

File(s)	Change Summary
apps/web/app/(app)/cold-email-blocker/TestRules.tsx apps/web/components/…/EmailList.tsx	Added messageId parameter to function calls in test email and categorization event handlers.
apps/web/app/…/categorize/controller.ts apps/web/app/…/categorize/validation.ts	Renamed function aicategorize to aiCategorize and added messageId (string) to the categorizeBody schema.
apps/web/utils/actions/cold-email.ts apps/web/utils/actions/validation.ts apps/web/utils/cold-email/is-cold-email.ts apps/web/utils/gmail/message.ts	Integrated messageId into email processing utilities by adding or substituting messageId for threadId in function parameters, validation schemas, and logging.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant API
    participant Validator
    participant ColdEmailUtils
    participant GmailService

    User->>UI: Trigger email test/categorization
    UI->>API: Call testEmail/categorizeEmailAction (includes messageId)
    API->>Validator: Validate payload (with messageId)
    Validator-->>API: Return validated data
    API->>ColdEmailUtils: Process email using messageId
    ColdEmailUtils->>GmailService: Check previous emails (via messageId)
    GmailService-->>ColdEmailUtils: Return email history result
    ColdEmailUtils-->>API: Return processing result
    API-->>UI: Send response

Loading

Possibly related PRs

• Fix bug with not handling cold email follow up properly #322: Modifications related to introducing messageId into cold email handling functions, paralleling the changes in email validation and processing.

Poem

I'm a rabbit with ears so perked,
Hopping on bugs that once had irked.
New messageId leads the way,
In emails now it holds its sway.
With code so fresh, let's celebrate today!
(_/)(●_●)
Hop along for a smoother display!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0e2211 and 134fdd9.

📒 Files selected for processing (8)

• apps/web/app/(app)/cold-email-blocker/TestRules.tsx (2 hunks)
• apps/web/app/api/ai/categorize/controller.ts (2 hunks)
• apps/web/app/api/ai/categorize/validation.ts (1 hunks)
• apps/web/components/email-list/EmailList.tsx (1 hunks)
• apps/web/utils/actions/cold-email.ts (1 hunks)
• apps/web/utils/actions/validation.ts (1 hunks)
• apps/web/utils/cold-email/is-cold-email.ts (3 hunks)
• apps/web/utils/gmail/message.ts (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• apps/web/app/api/ai/categorize/controller.ts

🔇 Additional comments (10)

apps/web/app/api/ai/categorize/validation.ts (1)

3-8: LGTM! Good schema definition.

The addition of messageId as a required field enhances message tracking precision and maintains data integrity.

apps/web/utils/actions/cold-email.ts (1)

120-131: LGTM! Proper messageId propagation.

The messageId is correctly passed through to the isColdEmail function, maintaining data consistency.

apps/web/utils/gmail/message.ts (2)

102-116: LGTM! Improved email identification precision.

The switch from threadId to messageId enhances accuracy in identifying previous emails. The added comment improves code clarity.

---

134-151: LGTM! Consistent implementation.

The hasPreviousEmailsFromSenderOrDomain function maintains consistency with the messageId changes.

apps/web/utils/actions/validation.ts (1)

202-211: Verify the nullable requirement for messageId.

While the implementation is correct, there's an inconsistency in how messageId is handled across schemas:

• It's required in categorizeBody
• It's nullable in coldEmailBlockerBody

Please verify if this difference is intentional.

apps/web/utils/cold-email/is-cold-email.ts (3)

23-93: LGTM!

The function correctly integrates the new messageId property for enhanced email identification and logging.

---

157-174: LGTM!

The function correctly integrates the new messageId property while maintaining its core functionality.

---

176-231: LGTM!

The function correctly uses the messageId for database operations while maintaining its core functionality.

apps/web/app/(app)/cold-email-blocker/TestRules.tsx (2)

92-105: LGTM!

The function correctly sets messageId to null for test emails, which is appropriate as these are simulated emails.

---

162-172: LGTM!

The function correctly passes the actual message ID when testing real emails, enabling accurate testing.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.