Skip to content

assistant: Add markdown styling to Knowledge base form #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elie222 merged 3 commits into from
Jan 1, 2026
Merged

assistant: Add markdown styling to Knowledge base form #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82f8f00
feat(assistant): add markdown styling to Knowledge base form
elie222 Jan 1, 2026
f2398d8
fix: update meeting briefing test snapshots for search tools
elie222 Jan 1, 2026
5d49735
update command
elie222 Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .cursor/commands/create-pr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ Important: don't use sandbox mode as the commands won't work in sandbox.
git branch --show-current && git status -s && git diff HEAD --stat
```

- If on `main`: create a branch using the appropriate prefix:
- **Always create a new branch for each PR** unless you're already on the correct branch for the current changes.
- If on `main` OR if the current branch doesn't match the work you're committing: create a branch using the appropriate prefix:
- `feat/<description>` - new features
- `fix/<description>` - bug fixes
- `chore/<description>` - maintenance, refactoring, etc.
Expand Down Expand Up @@ -53,4 +54,4 @@ gh pr create --title "<title>" --body "<body>"
gh pr create --title "<title>" --body "<body>" && gh pr comment $(gh pr view --json number -q .number) --body "#skipreview"
```

Display the returned PR URL on its own line so it's clickable.
Display the returned PR URL as a markdown link on its own line, formatted as: `[PR #<number>](<url>)` so it's clickable.
2 changes: 1 addition & 1 deletion apps/web/app/(app)/[emailAccountId]/assistant/knowledge/KnowledgeForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export function KnowledgeForm({
<Tiptap
ref={editorRef}
initialContent={field.value ?? ""}
className="mt-1"
className="mt-1 prose prose-sm dark:prose-invert max-w-none"
autofocus={false}
/>
</div>
Expand Down
10 changes: 7 additions & 3 deletions apps/web/utils/ai/meeting-briefs/generate-briefing.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
const prompt = buildPrompt(briefingData, "America/Sao_Paulo");

// The past meeting should show "4:00 PM" (Brazil time), NOT "7:00 PM" (UTC)
expect(prompt).toMatchInlineSnapshot(`

Check failure on line 63 in apps/web/utils/ai/meeting-briefs/generate-briefing.test.ts

View workflow job for this annotation

GitHub Actions / test

utils/ai/meeting-briefs/generate-briefing.test.ts > buildPrompt timezone handling > formats past meeting times in the user's timezone (not UTC) 

Error: Snapshot `buildPrompt timezone handling > formats past meeting times in the user's timezone (not UTC) 1` mismatched

- Expected
+ Received

@@ -20,11 +20,10 @@
  </recent_meetings>
  </guest>

  </guest_context>

- Available search tools: perplexitySearch, webSearch

  For each guest listed above:
  1. Review their email and meeting history provided
  2. Use search tools to find their professional background
  3. Once you have all information, call finalizeBriefing with the complete briefing"

 ❯ utils/ai/meeting-briefs/generate-briefing.test.ts:63:20
"Prepare a concise briefing for this upcoming meeting.

<upcoming_meeting>
Expand All @@ -85,9 +85,11 @@

</guest_context>

Available search tools: perplexitySearch, webSearch

For each guest listed above:
1. Review their email and meeting history provided
2. Use the researchGuest tool to find their professional background
2. Use search tools to find their professional background
3. Once you have all information, call finalizeBriefing with the complete briefing"
`);
});
Expand All @@ -111,7 +113,7 @@

const prompt = buildPrompt(briefingData, "America/Sao_Paulo");

expect(prompt).toMatchInlineSnapshot(`

Check failure on line 116 in apps/web/utils/ai/meeting-briefs/generate-briefing.test.ts

View workflow job for this annotation

GitHub Actions / test

utils/ai/meeting-briefs/generate-briefing.test.ts > buildPrompt timezone handling > shows no prior context for new contacts 

Error: Snapshot `buildPrompt timezone handling > shows no prior context for new contacts 1` mismatched

- Expected
+ Received

@@ -13,11 +13,10 @@
  <no_prior_context>This appears to be a new contact with no prior email or meeting history. Use search tools to find information about them.</no_prior_context>
  </guest>

  </guest_context>

- Available search tools: perplexitySearch, webSearch

  For each guest listed above:
  1. Review their email and meeting history provided
  2. Use search tools to find their professional background
  3. Once you have all information, call finalizeBriefing with the complete briefing"

 ❯ utils/ai/meeting-briefs/generate-briefing.test.ts:116:20
"Prepare a concise briefing for this upcoming meeting.

<upcoming_meeting>
Expand All @@ -124,14 +126,16 @@
Name: New Person
Email: newcontact@other.com

<no_prior_context>This appears to be a new contact with no prior email or meeting history. Use the researchGuest tool to find information about them.</no_prior_context>
<no_prior_context>This appears to be a new contact with no prior email or meeting history. Use search tools to find information about them.</no_prior_context>
</guest>

</guest_context>

Available search tools: perplexitySearch, webSearch

For each guest listed above:
1. Review their email and meeting history provided
2. Use the researchGuest tool to find their professional background
2. Use search tools to find their professional background
3. Once you have all information, call finalizeBriefing with the complete briefing"
`);
});
Expand Down
Loading