Skip to content

Comments

assistant: Add markdown styling to Knowledge base form#1167

Merged
elie222 merged 3 commits intomainfrom
feat/knowledge-markdown-styling
Jan 1, 2026
Merged

assistant: Add markdown styling to Knowledge base form#1167
elie222 merged 3 commits intomainfrom
feat/knowledge-markdown-styling

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented Jan 1, 2026

User description

TLDR: Added Tailwind Typography (prose) classes to the Knowledge Base Tiptap editor instance to render markdown visually.

  • Added prose classes to Tiptap instance in KnowledgeForm.
  • Kept Tiptap component generic to avoid side effects on other editor instances.

Generated description

Below is a concise technical summary of the changes proposed in this PR:
Integrate Tailwind Typography classes into the Tiptap editor within the KnowledgeForm component to visually render markdown content, ensuring the component remains generic. Additionally, update the AI meeting briefing prompts to leverage a broader set of search tools and refine internal documentation for pull request creation.

TopicDetails
Render Markdown Apply Tailwind Typography classes to the Tiptap editor in KnowledgeForm to visually render markdown content.
Modified files (1)
  • apps/web/app/(app)/[emailAccountId]/assistant/knowledge/KnowledgeForm.tsx
Latest Contributors(1)
UserCommitDate
elie222fix-up-imports-forNovember 22, 2025
System & Docs Updates Update AI meeting briefing prompts to utilize a broader set of perplexitySearch and webSearch tools, and refine internal documentation for pull request creation guidelines.
Modified files (2)
  • apps/web/utils/ai/meeting-briefs/generate-briefing.test.ts
  • .cursor/commands/create-pr.md
Latest Contributors(1)
UserCommitDate
elie222fix-testsJanuary 01, 2026
This pull request is reviewed by Baz. Review like a pro on (Baz).

@vercel
Copy link

vercel bot commented Jan 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
inbox-zero Ready Ready Preview Jan 1, 2026 4:25pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 1, 2026

Warning

Rate limit exceeded

@elie222 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 54 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f2398d8 and 5d49735.

📒 Files selected for processing (1)
  • .cursor/commands/create-pr.md
📝 Walkthrough

Walkthrough

Updated editor styling in the Knowledge Form, post-PR output formatting in PR creation docs, and prompt text in meeting-brief tests. Changes are presentation/text-only; no logic or API behavior altered.

Changes

Cohort / File(s) Summary
Tiptap Editor Styling
apps/web/app/(app)/[emailAccountId]/assistant/knowledge/KnowledgeForm.tsx
Added typography/prose-related classes and dark-mode adjustments to the editor container; removed default max-width constraints. No logic changes.
PR Output Formatting
.cursor/commands/create-pr.md
Changed post-PR display to render the returned PR URL as a markdown hyperlink on its own line formatted [PR #<number>](<url>) instead of raw URL.
Test Prompt Text
apps/web/utils/ai/meeting-briefs/generate-briefing.test.ts
Replaced references to a specialized tool with generic "search tools", explicitly listed available search tools in prompt text and updated inline snapshots accordingly. No control-flow changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • anakarentorosserrano-star
  • edulelis

Poem

🐰 A tweak of prose, a dash of light,
Dark and bright now read just right,
Links that point and tests that tell,
Small hops of change — all’s well,
A rabbit cheers: design takes flight! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title directly aligns with the main objective: adding markdown styling (Tailwind Typography prose classes) to the Knowledge Base Tiptap editor form.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@macroscopeapp
Copy link
Contributor

macroscopeapp bot commented Jan 1, 2026

Apply markdown prose styling and dark mode to the KnowledgeForm editor in KnowledgeForm.tsx

Updates the Knowledge base form editor styling by adding prose, prose-sm, dark:prose-invert, and max-w-none classes. Adjusts PR creation guidance to always create a new branch and require a single-line markdown PR link. Updates meeting brief tests to expect generic search tools and list available tools.

📍Where to Start

Start with the Tiptap editor styling changes in KnowledgeForm.tsx.


Macroscope summarized 5d49735.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@elie222 elie222 merged commit ce63830 into main Jan 1, 2026
11 of 14 checks passed
@elie222 elie222 deleted the feat/knowledge-markdown-styling branch January 1, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant