Skip to content

Comments

Add support for libnm 1.43#357

Merged
tintou merged 3 commits intomasterfrom
libnm-1_43
Apr 24, 2023
Merged

Add support for libnm 1.43#357
tintou merged 3 commits intomasterfrom
libnm-1_43

Conversation

@meisenzahl
Copy link
Member

Below are the versions of libnm that Fedora uses:

  • Fedora 37: 1.40.10-1
  • Fedora 38: 1.42.6-1
  • Fedora Rawhide: 1.43.6-1

This project could not be compiled on Fedora Rawhide.

Before

After

@tintou I'm not sure if we need to fix the problem or if it's a bug in the bindings for Vala. What do you think?

@tintou
Copy link
Member

tintou commented Apr 24, 2023

Two suggestions but it looks good, this is due to a renamespace that I did in https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4d325bafe193dc1fc4fbd0beabae7bb6ab8901bc

Co-authored-by: Corentin Noël <tintou@noel.tf>
@meisenzahl
Copy link
Member Author

@tintou thanks for your suggestions. I validated that it still compiles: https://github.com/meisenzahl/distro-agnostic/actions/runs/4782964418/jobs/8511499466

Copy link
Member Author

@meisenzahl meisenzahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the compile definition from HAS_NM_1_43 to HAS_NM_1_43_3?

@tintou
Copy link
Member

tintou commented Apr 24, 2023

I'm unsure because odd number mean unstable release so at the end it would be HAS_NM_1_44 if we want to be correct 🤷

@meisenzahl
Copy link
Member Author

That would seem weird to me based on the version number. Then let's stick with HAS_NM_1_43. Unless you prefer HAS_NM_1_44.

@tintou tintou merged commit 50c06ca into master Apr 24, 2023
@tintou tintou deleted the libnm-1_43 branch April 24, 2023 13:49
@vcunat
Copy link

vcunat commented Oct 22, 2023

NM 1.44 was released two months ago. It would be nice to have a tag supporting that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants