Skip to content

Comments

pantheon.switchboard-plug-network: 2.4.4 -> unstable-2023-09-05#262683

Merged
bobby285271 merged 1 commit intoNixOS:masterfrom
vcunat:p/pantheon.switchboard-plug-network
Oct 22, 2023
Merged

pantheon.switchboard-plug-network: 2.4.4 -> unstable-2023-09-05#262683
bobby285271 merged 1 commit intoNixOS:masterfrom
vcunat:p/pantheon.switchboard-plug-network

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 22, 2023

It would fail to build, as networkmanager got upgraded inside #257792

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Oct 22, 2023
@vcunat vcunat requested review from bobby285271 and davidak October 22, 2023 06:57
@github-actions github-actions bot added the 6.topic: pantheon The Pantheon desktop environment label Oct 22, 2023
@vcunat
Copy link
Member Author

vcunat commented Oct 22, 2023

I pinged upstream about missing release:
elementary/settings-network#357 (comment)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 22, 2023
@bobby285271 bobby285271 self-assigned this Oct 22, 2023
@bobby285271
Copy link
Member

LGTM. Briefly tested.

@bobby285271 bobby285271 merged commit 82b053d into NixOS:master Oct 22, 2023
@vcunat vcunat deleted the p/pantheon.switchboard-plug-network branch October 22, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants