Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursors: new base cursor design #1258

Merged
merged 13 commits into from
Apr 23, 2024
Merged

Cursors: new base cursor design #1258

merged 13 commits into from
Apr 23, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Apr 22, 2024 •
edited
Loading

Based on #1256

  • Redraw base arrow to have rounded corners and thicker stem
  • Make the stemless arrow use the same arrow body
  • Use same shadow technique as main icons to prevent shadow bleed and make sure shadows are consistent even with different shapes

@danirabbit danirabbit changed the title Danirabbit/cursors arrowredraw Cursors: new base cursor design Apr 22, 2024
@danirabbit danirabbit force-pushed the danirabbit/cursors-arrowredraw branch from 71331d7 to 2c52c6d Compare April 22, 2024 21:03
@danirabbit danirabbit requested review from a team and newhoa April 22, 2024 21:03
@danirabbit
Copy link
Member Author

@wpkelso would love your feedback here as well :)

@danirabbit danirabbit marked this pull request as ready for review April 22, 2024 21:04
@danirabbit danirabbit marked this pull request as draft April 22, 2024 21:27
@danirabbit danirabbit force-pushed the danirabbit/cursors-arrowredraw branch from 509f989 to 2c52c6d Compare April 22, 2024 21:30
@danirabbit danirabbit marked this pull request as ready for review April 22, 2024 21:30
wpkelso
wpkelso reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@wpkelso wpkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The white outlines on the emblems feel to me like they're interfering with the white symbols a fair amount. Perhaps some middle ground with a flatter emblem and a darker outline would work better in this respect?

cursors/24/no-drop.svg Show resolved Hide resolved
cursors/24/default.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely like this shape, its quite playful

cursors/24/help.svg Show resolved Hide resolved
@danirabbit danirabbit requested a review from wpkelso April 23, 2024 15:33
wpkelso
wpkelso reviewed Apr 23, 2024
View reviewed changes
cursors/24/progress_01.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if a mesh gradient would work here for smoother transitions? I don't know whether rsvg supports them, but it could be a thought for the future.

wpkelso
wpkelso approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@wpkelso wpkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how consistent everything feels now

@danirabbit
Copy link
Member Author

Thank you so much for your help!

@danirabbit danirabbit merged commit 5c01d00 into main Apr 23, 2024
3 checks passed
@danirabbit danirabbit deleted the danirabbit/cursors-arrowredraw branch April 23, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpkelso wpkelso wpkelso approved these changes

@newhoa newhoa Awaiting requested review from newhoa

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cursors
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @wpkelso