Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursors: rename to fit spec #1256

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Cursors: rename to fit spec #1256

merged 5 commits into from
Apr 22, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Apr 22, 2024 •
edited
Loading

Closes #895
Fixes #1255
Fixes #1073

  • Drops cursor names that are no longer supported/aren't in the CSS spec
  • Renames existing cursors to spec names
  • Make sure we have symlinks for cursors we aren't covering right now
  • Adds context menu cursor
  • uses a colorful badged help icon instead of the large question mark

@danirabbit danirabbit requested a review from tintou April 22, 2024 17:25
@danirabbit danirabbit marked this pull request as ready for review April 22, 2024 17:25
@danirabbit danirabbit mentioned this pull request Apr 22, 2024
Closed
@danirabbit danirabbit requested a review from a team April 22, 2024 18:41
@danirabbit danirabbit mentioned this pull request Apr 22, 2024
Merged
tintou
tintou approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me!

@danirabbit danirabbit merged commit 29ade4a into main Apr 22, 2024
3 checks passed
@danirabbit danirabbit deleted the danirabbit/cursors-specrename branch April 22, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cursors
Status: Done
Milestone
No milestone
2 participants
@danirabbit @tintou