Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to bump libjemalloc version on latest debian; correct "push_rules" stream name #17171

Merged
merged 5 commits into from
May 9, 2024
Merged

Update docs to bump libjemalloc version on latest debian; correct "push_rules" stream name #17171

merged 5 commits into from
May 9, 2024

Conversation

ll-SKY-ll
Copy link
Contributor

@ll-SKY-ll ll-SKY-ll commented May 8, 2024 •
edited
Loading

debian 12 uses libjemalloc2

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@ll-SKY-ll
Update admin_faq.md
0637dd1 
debian 12 uses libjemalloc2
@ll-SKY-ll ll-SKY-ll requested a review from a team as a code owner May 8, 2024 22:09
@CLAassistant
Copy link

CLAassistant commented May 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

anoadragon453
anoadragon453 requested changes May 9, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it does, thank you!

Before we can merge this commit, can you sign off on your changes such that we can include this in the repository? The button in this comment above will let you do so.

As part of our contribution process, we also require a changelog entry. In the case of this PR, this would take the form of a file at changelog.d/17171.doc with text that describes the change you made. Something like:

Update the Admin FAQ with the current libjemalloc version for latest Debian stable.

Thank you (and nice PR number btw)!

@ll-SKY-ll
Copy link
Contributor Author

ll-SKY-ll commented May 9, 2024 •
edited
Loading

Indeed it does, thank you!

Before we can merge this commit, can you sign off on your changes such that we can include this in the repository? The button in this comment above will let you do so.

As part of our contribution process, we also require a changelog entry. In the case of this PR, this would take the form of a file at changelog.d/17171.doc with text that describes the change you made. Something like:

Update the Admin FAQ with the current libjemalloc version for latest Debian stable.

Thank you (and nice PR number btw)!

hi, sorry its my first time doing anything on github :) I just happen to optimize my server and stumbled across these errors in the docs so i wanted to update them :)

I included the update of the workers.md where the name of a stream was different in the text as compared to the headline (where it was correct) leading to a invalid homeserver.yaml for me when i tried to start synapse with the wrong stream name.

I also updated the changelog file again to also include a description of this change :) i hope everything is right now.

anoadragon453
anoadragon453 approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small adjustment to the changelog to make it fit the guidelines, otherwise looks good to me! Thanks for making the other fix as well.

changelog.d/17171.doc Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 enabled auto-merge (squash) May 9, 2024 10:49
@anoadragon453 anoadragon453 disabled auto-merge May 9, 2024 10:49
@github-actions github-actions bot deployed to PR Documentation Preview May 9, 2024 10:49 Active
@anoadragon453 anoadragon453 changed the title Update admin_faq.md Update docs to bump libjemalloc version on latest debian; correct "push_rules" stream name May 9, 2024
@anoadragon453 anoadragon453 enabled auto-merge (squash) May 9, 2024 10:49
@anoadragon453 anoadragon453 merged commit 4cf4a82 into element-hq:develop May 9, 2024
31 checks passed
yingziwu added a commit to yingziwu/synapse that referenced this pull request Jun 7, 2024
@yingziwu
Merge tag 'v1.108.0' into develop
bff6843 
No significant changes since 1.108.0rc1.

- Add a feature that allows clients to query the configured federation whitelist. Disabled by default. ([\#16848](element-hq/synapse#16848), [\#17199](element-hq/synapse#17199))
- Add the ability to allow numeric user IDs with a specific prefix when in the CAS flow. Contributed by Aurélien Grimpard. ([\#17098](element-hq/synapse#17098))

- Fix bug where push rules would be empty in `/sync` for some accounts. Introduced in v1.93.0. ([\#17142](element-hq/synapse#17142))
- Add support for optional whitespace around the Federation API's `Authorization` header's parameter commas. ([\#17145](element-hq/synapse#17145))
- Fix bug where disabling room publication prevented public rooms being created on workers. ([\#17177](element-hq/synapse#17177), [\#17184](element-hq/synapse#17184))

- Document [`/v1/make_knock`](https://spec.matrix.org/v1.10/server-server-api/#get_matrixfederationv1make_knockroomiduserid) and [`/v1/send_knock/`](https://spec.matrix.org/v1.10/server-server-api/#put_matrixfederationv1send_knockroomideventid) federation endpoints as worker-compatible. ([\#17058](element-hq/synapse#17058))
- Update User Admin API with note about prefixing OIDC external_id providers. ([\#17139](element-hq/synapse#17139))
- Clarify the state of the created room when using the `autocreate_auto_join_room_preset` config option. ([\#17150](element-hq/synapse#17150))
- Update the Admin FAQ with the current libjemalloc version for latest Debian stable. Additionally update the name of the "push_rules" stream in the Workers documentation. ([\#17171](element-hq/synapse#17171))

- Add note to reflect that [MSC3886](matrix-org/matrix-spec-proposals#3886) is closed but will remain supported for some time. ([\#17151](element-hq/synapse#17151))
- Update dependency PyO3 to 0.21. ([\#17162](element-hq/synapse#17162))
- Fixes linter errors found in PR #17147. ([\#17166](element-hq/synapse#17166))
- Bump black from 24.2.0 to 24.4.2. ([\#17170](element-hq/synapse#17170))
- Cache literal sync filter validation for performance. ([\#17186](element-hq/synapse#17186))
- Improve performance by fixing a reactor pause. ([\#17192](element-hq/synapse#17192))
- Route `/make_knock` and `/send_knock` federation APIs to the federation reader worker in Complement test runs. ([\#17195](element-hq/synapse#17195))
- Prepare sync handler to be able to return different sync responses (`SyncVersion`). ([\#17200](element-hq/synapse#17200))
- Organize the sync cache key parameter outside of the sync config (separate concerns). ([\#17201](element-hq/synapse#17201))
- Refactor `SyncResultBuilder` assembly to its own function. ([\#17202](element-hq/synapse#17202))
- Rename to be obvious: `joined_rooms` -> `joined_room_ids`. ([\#17203](element-hq/synapse#17203), [\#17208](element-hq/synapse#17208))
- Add a short pause when rate-limiting a request. ([\#17210](element-hq/synapse#17210))

* Bump cryptography from 42.0.5 to 42.0.7. ([\#17180](element-hq/synapse#17180))
* Bump gitpython from 3.1.41 to 3.1.43. ([\#17181](element-hq/synapse#17181))
* Bump immutabledict from 4.1.0 to 4.2.0. ([\#17179](element-hq/synapse#17179))
* Bump sentry-sdk from 1.40.3 to 2.1.1. ([\#17178](element-hq/synapse#17178))
* Bump serde from 1.0.200 to 1.0.201. ([\#17183](element-hq/synapse#17183))
* Bump serde_json from 1.0.116 to 1.0.117. ([\#17182](element-hq/synapse#17182))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ll-SKY-ll @CLAassistant @anoadragon453