Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill behavior changes #505

Closed
wants to merge 4 commits into from
Closed

Conversation

DanilaFe
Copy link
Contributor

@DanilaFe DanilaFe commented Sep 21, 2021

Fixes #393

I still want to take a look at what to do (if anything) with the expected overlapping event ID.

@DanilaFe
Copy link
Contributor Author

Some questions:

  • Does encountering the "expected overlap ID" change our decision (i.e., close gap even if not all events overlap)
  • Can we accidentally advance the token past the edge of the proper fragment, at which point the gap will never be filled?
  • Is picking the first overlapping event for the fragment sufficient? Do we want all fragments to match? Is there another heuristic?

@bwindels bwindels changed the base branch from DanilaFe/backfill-changes to master September 23, 2021 09:16
@bwindels bwindels marked this pull request as ready for review September 23, 2021 11:40
@bwindels bwindels marked this pull request as draft September 23, 2021 16:08
@bwindels
Copy link
Contributor

Working on an alternative solution in #508

@bwindels
Copy link
Contributor

Some questions:

All very good questions

* Does encountering the "expected overlap ID" change our decision (i.e., close gap even if not all events overlap)

Yeah, this seems reasonable. We might still miss events that were inserted in the neighbour fragment but that is not a problem we can solve while persisting history, and seems like a fine tradeoff. I've put this on the table for sync v3 fwiw,

* Can we accidentally advance the token past the edge of the proper fragment, at which point the gap will never be filled?

This is a very valid point and made me think if #508 is not a better approach. It would be easy to go too far if the neighbour fragment is small (e.g. 10 events).

* Is picking the first overlapping event for the fragment sufficient? Do we want all fragments to match? Is there another heuristic?

Indeed what I went with in the other PR in the end.

@bwindels bwindels closed this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History is swallowed before point of joining room
2 participants