Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History is swallowed before point of joining room #393

Closed
bwindels opened this issue Jun 10, 2021 · 0 comments · Fixed by #508
Closed

History is swallowed before point of joining room #393

bwindels opened this issue Jun 10, 2021 · 0 comments · Fixed by #508
Assignees
Labels
bug Something isn't working

Comments

@bwindels
Copy link
Contributor

Caused by #160 mitigation.

I guess Hydrogen could be a bit more forgiving in how it handles duplicate events in /messages

It assumes that the first duplicate event is on a different fragment and that your pagination is colliding into that fragment and hence they need to be linked up and the rest of the events will also overlap with the fragment. If that fragment is the same as the fragment who's gap your filling, it screams #160 and prevents it linking up with itself.

Perhaps I could check overlap for every event in the /messages response and filter out the ones on the same fragment.

I also wonder if federation makes this more likely to happen on the server side. IIRC federation can cause events through /sync and /messages to be in different order. I've filed this before as matrix-org/synapse#7164 but it's expected (and somewhat underspecced) behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants