Unit tests for GapWriter, using a new timeline mock utility #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
commented
Sep 14, 2021
bwindels
changed the title
bwindels
commented
Sep 15, 2021
| return { | ||
| "Backfilling an empty fragment": async assert => { | ||
| const { txn, fragmentIdComparer, gapWriter, eventCreator } = await setup(); | ||
| const emptyFragment = await createFragment(0, txn, fragmentIdComparer, { previousToken: startToken }); |
There was a problem hiding this comment.
can you extract the fragment id here in a variable and reuse it when you check for the results below in the store? Now the relation is implicit, by using EventKey.minKey which also happens to use fragmentId 0, making the test work, but it's not apparent without knowing all of this.
bwindels
commented
Sep 20, 2021
|
Excellent work on the unit tests! Left some comments, and have some questions about the actual fix, we can discuss "in person" later on. |
bwindels
changed the title
|
Good to go, thanks again for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.