Skip to content

Conversation

@pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 3, 2025

This PR takes the sound from element-hq/element-web#30804 and converts it as instructed in the UNNotificationSound docs so we can have the same new sound that web just got.

Thanks @beatdemon 👏

Edit: Now comes with an announcement banner!

651CA5B5-EFFA-4E03-AF85-74E64A65F0B4

@pixlwave pixlwave requested a review from a team as a code owner October 3, 2025 15:49
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 3, 2025 15:49
@pixlwave pixlwave added the pr-feature for a new feature label Oct 3, 2025
@codecov
Copy link

codecov bot commented Oct 3, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1139 1 1138 0
View the top 1 failed test(s) by shortest run time
StartChatScreenViewModelTests::testJoinRoomByAddressFailsBecauseNotFound()
Stack Traces | 12.8s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Other/Extensions/XCTestCase.swift:43)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

@pixlwave pixlwave merged commit 7e7cf15 into develop Oct 3, 2025
15 of 16 checks passed
@pixlwave pixlwave deleted the doug/notification-sound branch October 3, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants