Set a notification sound #5469
Set a notification sound #5469
Conversation
| } | ||
|
|
||
| var securityBannerDismissed by rememberSaveable { mutableStateOf(false) } | ||
| val showNewNotificationSoundBanner by appPreferencesStore.showNewNotificationSoundBanner().collectAsState(false) |
There was a problem hiding this comment.
Would be great to use the Announcement feature no?
There was a problem hiding this comment.
Yes, maybe, but here it's more embedded in the UI so it's probably easier like this.
There was a problem hiding this comment.
Can we find a more explicit name than message.mp3 ?
There was a problem hiding this comment.
I kept the original name from ElementWeb for consistency: https://github.com/element-hq/element-web/tree/develop/res/media
…rent way for an application upgrade or a fresh install. We cannot restore the previous code which existed because of #3535
bmarty
force-pushed
the
feature/bma/newSound
branch
from
b139ab9 to
98637b8
Compare
bmarty
added
the
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5469 +/- ##
========================================
Coverage 81.93% 81.94%
========================================
Files 2369 2371 +2
Lines 67151 67200 +49
Branches 8111 8115 +4
========================================
+ Hits 55021 55066 +45
- Misses 9156 9160 +4
Partials 2974 2974 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Content
This PR takes the sound from element-hq/element-web#30804 and the spec and design from element-hq/element-x-ios#4572
I had to update the migration codebase to be able to migrate differently in the case of app install of app upgrade.
I also had to set a new notification channel id since setting a new sound has no effect on already registered channels.
Motivation and context
All Element clients have the same notification sound.
Screenshots / GIFs
See recorded one. May include unrelated change due to the sync of strings.
Tests
Tested devices
Checklist