New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentioned notifications copy improvement #2144

Merged

Velin92 merged 3 commits into develop from mauroromito/mentioned_you_copy_improvement

Nov 22, 2023

Member

Velin92 commented Nov 22, 2023

fixes #2139


          mentioned you improvement

28cb379

Velin92 requested a review from a team as a code owner

November 22, 2023 12:52

Velin92 requested review from pixlwave and removed request for a team

November 22, 2023 12:52


          changelog

ee211a0

github-actions bot commented Nov 22, 2023 •

edited

Loading

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against cfcd50f

pixlwave approved these changes

View reviewed changes

Velin92 enabled auto-merge (squash)

November 22, 2023 12:56

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b8f4f8) 71.90% compared to head (ee211a0) 71.99%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2144      +/-   ##
===========================================
+ Coverage    71.90%   71.99%   +0.08%     
===========================================
  Files          511      511              
  Lines        34731    34731              
  Branches     16677    16677              
===========================================
+ Hits         24972    25003      +31     
+ Misses        9146     9114      -32     
- Partials       613      614       +1

Flag	Coverage Δ
unittests	`57.40% <ø> (+0.18%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


          Merge branch 'develop' into mauroromito/mentioned_you_copy_improvement

cfcd50f

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Velin92 disabled auto-merge

November 22, 2023 13:15

Velin92 merged commit d115626 into develop

4 of 5 checks passed

Velin92 deleted the mauroromito/mentioned_you_copy_improvement branch

November 22, 2023 13:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet