Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Foo mentioned you." in push notifications reduces the amount of useful information in the push notification by a line, and is confusable with the msg contents #2139

Closed
ara4n opened this issue Nov 21, 2023 · 3 comments · Fixed by #2144
Assignees
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design

Comments

@ara4n
Copy link
Member

ara4n commented Nov 21, 2023

Steps to reproduce

  1. Receive a push with a mention:

image

  1. Wince that the "Travis mentioned you." text occupies a whole line, meaning that (without long-tapping further) the push has 25% less useful info on it. On apple watch, it's even more annoying, as you no longer get any preview of the message as it only shows the first line of the push.

Outcome

What did you expect?

To be able to read as much contents of the push notif as possible.

If you really think it's useful to tell me that I was explicitly mentioned in the message, perhaps:

  • prefix the sender/room name with 🔔
  • suffix the sender/room name with " mentioned you"
  • ...etc

What happened instead?

I lost a line's worth of visible message, and the "Travis mentioned you." is ambiguous and confusable with the rest of the contents of the message itself.

Your phone model

No response

Operating system version

No response

Application version

440

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Nov 21, 2023
@ara4n ara4n changed the title "Foo mentinoed you." in push notifications reduces the amount of useful information in the push notification by a line "Foo mentioned you." in push notifications reduces the amount of useful information in the push notification by a line Nov 21, 2023
@ara4n ara4n changed the title "Foo mentioned you." in push notifications reduces the amount of useful information in the push notification by a line "Foo mentioned you." in push notifications reduces the amount of useful information in the push notification by a line, and is confusable with the msg contents Nov 21, 2023
@pixlwave pixlwave added X-Needs-Design A-Notifications S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Nov 22, 2023
@kittykat kittykat added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements and removed T-Defect labels Nov 22, 2023
@VolkerJunginger
Copy link

We modified the push. Hope this works better now. We believe that notifying the user that they have been mentioned is important because one reason to mention users is to generate extra awareness and urgency.

@ara4n
Copy link
Member Author

ara4n commented Nov 23, 2023

Looking at the PR: https://github.com/vector-im/element-x-ios/pull/2144/files#diff-820dd031991c61213a1d080e54adb928764207a7e040523ead2060db18e08558R241 it seems like we're going from "Foo mentioned you" on a dedicated line to "Mentioned you: $msg" (which is grammatically incorrect thanks to the capital letter, and the fact that it follows after the room name, not the sender name; plus it will get confused with the message body). For instance, in the example in this bug, it'll render as:

TravisR
Office of the Spec Core Team
Mentioned you: Hey all it's Tuesday

The end result is similar: the fact that a message is a mention ends up taking higher priority than telling you what the actual message actually is (especially on apple watch, or other UIs which only show the beginning of the message).

I agree that it's somewhat useful to tell the user that they have been explicitly mentioned but not at the expense of truncating the push contents, which is surely way more important. Would it be possible to come up with a more discreet indicator (e.g. prepending with 🔔)?

@ara4n ara4n reopened this Nov 23, 2023
@pixlwave
Copy link
Member

pixlwave commented Oct 2, 2024

Fixed by #3142 although #2397 has more discussion about that.

@pixlwave pixlwave closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants