Skip to content

Comments

Lazy use the OkHttpClient.#552

Merged
bmarty merged 1 commit intodevelopfrom
feature/bma/lazyOkHttp
Jun 7, 2023
Merged

Lazy use the OkHttpClient.#552
bmarty merged 1 commit intodevelopfrom
feature/bma/lazyOkHttp

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Jun 7, 2023

I missed that change when reviewing #542.
I think it's better to lazy load the OkHttpClient.

@bmarty bmarty requested a review from a team as a code owner June 7, 2023 07:07
@bmarty bmarty requested review from ganfra and removed request for a team June 7, 2023 07:07
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9e5add9) 52.06% compared to head (f2852dd) 52.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #552   +/-   ##
========================================
  Coverage    52.06%   52.06%           
========================================
  Files          758      758           
  Lines        18215    18215           
  Branches      3860     3860           
========================================
  Hits          9483     9483           
  Misses        7159     7159           
  Partials      1573     1573           
Impacted Files Coverage Δ
...ement/android/libraries/network/RetrofitFactory.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/u5pVwu

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good catch!

@bmarty bmarty merged commit c6ad800 into develop Jun 7, 2023
@bmarty bmarty deleted the feature/bma/lazyOkHttp branch June 7, 2023 14:39
bmarty added a commit that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants