Merged
Conversation
julioromano
requested review from
bmarty and
ganfra
and removed request for
a team and
ganfra
julioromano
force-pushed
the
misc/julioromano/network_lib_changes
branch
from
7f92e1d to
eb55ff3
Compare
- Allows for http2 - Caches a global instance of kotlinx-serialization `Json` and configures it with a bit more leniency. - Moves okhttp's dependency strings to the .toml file - Switches off logging for release builds
julioromano
force-pushed
the
misc/julioromano/network_lib_changes
branch
from
eb55ff3 to
2cbefc3
Compare
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #542 +/- ##
========================================
Coverage 51.35% 51.35%
========================================
Files 762 762
Lines 18511 18510 -1
Branches 3990 3990
========================================
Hits 9506 9506
+ Misses 7344 7343 -1
Partials 1661 1661
☔ View full report in Codecov by Sentry. |
bmarty
approved these changes
Jun 6, 2023
| ): OkHttpClient { | ||
| return OkHttpClient.Builder() | ||
| // workaround for #4669 | ||
| .protocols(listOf(Protocol.HTTP_1_1)) |
Member
There was a problem hiding this comment.
It was a workaround for element-hq/element-android#4669, but I guess in this project, we will not have the same issue.
| .addInterceptor(httpLoggingInterceptor) | ||
| .build() | ||
| fun providesJson(): Json = Json { | ||
| ignoreUnknownKeys = true |
Member
There was a problem hiding this comment.
Thanks, I have also added this on my branch, but my branch is far from being mergeable :)
bmarty
pushed a commit
that referenced
this pull request
Jul 19, 2023
- Allows for http2 - Caches a global instance of kotlinx-serialization `Json` and configures it with a bit more leniency. - Moves okhttp's dependency strings to the .toml file - Switches off logging for release builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jsonand configures it with a bit more leniency.