Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslashes added when quoting a message containing markdown formatting #9231

Closed
anoadragon453 opened this issue Mar 21, 2019 · 4 comments
Closed

Comments

@anoadragon453
Copy link
Member

Description

Quoting a message that contains some markdown will causing spurious backslashes to be added, escaping punctuation and parentheses etc.

image

I presume it's because we convert the HTML back to non-markdown or something? But we can just take the body which is perfectly fine:

"body": "This is a *message* containing markdown. Thanks for listening (<3)"

Might be related to #7324

Steps to reproduce

  • Send a message with markdown such as This is (really) *great*.
  • Quote the message
  • Notice \ escape characters inserted

Version information

  • Platform: web
  • Browser: Chrome
  • OS: Debian Linux
  • URL: independent build of riot.im/develop
@t3chguy
Copy link
Member

t3chguy commented Mar 21, 2019

I presume it's because we convert the HTML back to non-markdown or something? But we can just take the body which is perfectly fine:

The body being correct markdown is just a riot-web thing, mobile clients don't match iirc and other clients probably don't either so this is definitely not a good approach.

@anoadragon453
Copy link
Member Author

Ah, unfortunate :/

Well then perhaps just a second pass after the parser goes would work.

@ssokolow
Copy link

ssokolow commented Feb 15, 2020

I've found that trying to escape *chuckle* so it doesn't get interpreted as italics results in the escape showing up in the output too (\*chuckle*).

Would this be the same bug or should I file a new one?

EDIT: To be clear, I'm on https://riot.im/app/ (freshly reloaded on 2020-02-14 at around 10:30PM EST to be sure I'm on the lastest version) and, if I type *chuckle*, it gets converted to _chuckle_ and interpreted as italics while, if I type \*chuckle*, it produces a literal \*chuckle*.

@jryans
Copy link
Collaborator

jryans commented Nov 20, 2020

This does not seem to an issue with the current composer.

@jryans jryans closed this as completed Nov 20, 2020
su-ex added a commit to SchildiChat/element-web that referenced this issue Sep 15, 2022
* Device manager - hide unverified security recommendation when only current session is unverified ([\element-hq#9228](matrix-org/matrix-react-sdk#9228)). Contributed by @kerryarchibald.
* Device manager - scroll to filtered list from security recommendations ([\element-hq#9227](matrix-org/matrix-react-sdk#9227)). Contributed by @kerryarchibald.
* Device manager - updated dropdown style in filtered device list ([\element-hq#9226](matrix-org/matrix-react-sdk#9226)). Contributed by @kerryarchibald.
* Device manager - device type and verification icons on device tile ([\element-hq#9197](matrix-org/matrix-react-sdk#9197)). Contributed by @kerryarchibald.
* Description of DM room with more than two other people is now being displayed correctly ([\element-hq#9231](matrix-org/matrix-react-sdk#9231)). Fixes element-hq#23094.
* Fix voice messages with multiple composers ([\element-hq#9208](matrix-org/matrix-react-sdk#9208)). Fixes element-hq#23023. Contributed by @grimhilt.
* Fix suggested rooms going missing ([\element-hq#9236](matrix-org/matrix-react-sdk#9236)). Fixes element-hq#23190.
* Fix tooltip infinitely recursing ([\element-hq#9235](matrix-org/matrix-react-sdk#9235)). Fixes matrix-org/element-web-rageshakes#15107, matrix-org/element-web-rageshakes#15093 matrix-org/element-web-rageshakes#15092 and matrix-org/element-web-rageshakes#15077.
* Fix plain text export saving ([\element-hq#9230](matrix-org/matrix-react-sdk#9230)). Contributed by @jryans.
* Add missing space in SecurityRoomSettingsTab ([\element-hq#9222](matrix-org/matrix-react-sdk#9222)). Contributed by @gefgu.
* Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\element-hq#9209](matrix-org/matrix-react-sdk#9209)). Fixes element-hq#21369.
* Fix progress bar regression throughout the app ([\element-hq#9219](matrix-org/matrix-react-sdk#9219)). Fixes element-hq#23121.
* Reuse empty string & space string logic for event types in devtools ([\element-hq#9218](matrix-org/matrix-react-sdk#9218)). Fixes element-hq#23115.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants