Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi party "pre-DM" screen incorrect subheader #23094

Closed
germain-gg opened this issue Aug 17, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#9231
Closed

multi party "pre-DM" screen incorrect subheader #23094

germain-gg opened this issue Aug 17, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#9231
Assignees
@weeman1337
Labels
A-DMs O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@germain-gg
Copy link
Contributor

Steps to reproduce

  1. Create a DM with Bob and Alice
  2. Land on the "pre-DM" screen

Outcome

Header: Bob and Alice 
-Caption: Send you first message to invite Bob to chat
+Caption: Send you first message to invite Bob and Alice to chat

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No
@germain-gg germain-gg added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-DMs O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 17, 2022
@robintown robintown mentioned this issue Aug 29, 2022
Closed
@weeman1337 weeman1337 self-assigned this Aug 30, 2022
@weeman1337 weeman1337 mentioned this issue Sep 1, 2022
Merged
3 tasks
@germain-gg
Copy link
Contributor Author

@kittykat i'm not sure that qualifies as a regression. It's a bug that happens only in the pre-DM screen and that did not exist beforehand.

@kittykat
Copy link
Contributor

kittykat commented Sep 6, 2022

I feel that it is a regression because the old flow had correct strings, and the new flow introduced one that was wrong

su-ex added a commit to SchildiChat/element-desktop that referenced this issue Sep 15, 2022
@su-ex
Merge tag 'v1.11.5' into sc
57d2087 
* Device manager - hide unverified security recommendation when only current session is unverified ([\#9228](matrix-org/matrix-react-sdk#9228)). Contributed by @kerryarchibald.
* Device manager - scroll to filtered list from security recommendations ([\#9227](matrix-org/matrix-react-sdk#9227)). Contributed by @kerryarchibald.
* Device manager - updated dropdown style in filtered device list ([\#9226](matrix-org/matrix-react-sdk#9226)). Contributed by @kerryarchibald.
* Device manager - device type and verification icons on device tile ([\#9197](matrix-org/matrix-react-sdk#9197)). Contributed by @kerryarchibald.
* Description of DM room with more than two other people is now being displayed correctly ([\#9231](matrix-org/matrix-react-sdk#9231)). Fixes element-hq/element-web#23094.
* Fix voice messages with multiple composers ([\#9208](matrix-org/matrix-react-sdk#9208)). Fixes element-hq/element-web#23023. Contributed by @grimhilt.
* Fix suggested rooms going missing ([\#9236](matrix-org/matrix-react-sdk#9236)). Fixes element-hq/element-web#23190.
* Fix tooltip infinitely recursing ([\#9235](matrix-org/matrix-react-sdk#9235)). Fixes matrix-org/element-web-rageshakes#15107, matrix-org/element-web-rageshakes#15093 matrix-org/element-web-rageshakes#15092 and matrix-org/element-web-rageshakes#15077.
* Fix plain text export saving ([\#9230](matrix-org/matrix-react-sdk#9230)). Contributed by @jryans.
* Add missing space in SecurityRoomSettingsTab ([\#9222](matrix-org/matrix-react-sdk#9222)). Contributed by @gefgu.
* Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\#9209](matrix-org/matrix-react-sdk#9209)). Fixes element-hq/element-web#21369.
* Fix progress bar regression throughout the app ([\#9219](matrix-org/matrix-react-sdk#9219)). Fixes element-hq/element-web#23121.
* Reuse empty string & space string logic for event types in devtools ([\#9218](matrix-org/matrix-react-sdk#9218)). Fixes element-hq/element-web#23115.
su-ex added a commit to SchildiChat/element-web that referenced this issue Sep 15, 2022
@su-ex
Merge tag 'v1.11.5' into sc
5c1a172 
* Device manager - hide unverified security recommendation when only current session is unverified ([\element-hq#9228](matrix-org/matrix-react-sdk#9228)). Contributed by @kerryarchibald.
* Device manager - scroll to filtered list from security recommendations ([\element-hq#9227](matrix-org/matrix-react-sdk#9227)). Contributed by @kerryarchibald.
* Device manager - updated dropdown style in filtered device list ([\element-hq#9226](matrix-org/matrix-react-sdk#9226)). Contributed by @kerryarchibald.
* Device manager - device type and verification icons on device tile ([\element-hq#9197](matrix-org/matrix-react-sdk#9197)). Contributed by @kerryarchibald.
* Description of DM room with more than two other people is now being displayed correctly ([\element-hq#9231](matrix-org/matrix-react-sdk#9231)). Fixes element-hq#23094.
* Fix voice messages with multiple composers ([\element-hq#9208](matrix-org/matrix-react-sdk#9208)). Fixes element-hq#23023. Contributed by @grimhilt.
* Fix suggested rooms going missing ([\element-hq#9236](matrix-org/matrix-react-sdk#9236)). Fixes element-hq#23190.
* Fix tooltip infinitely recursing ([\element-hq#9235](matrix-org/matrix-react-sdk#9235)). Fixes matrix-org/element-web-rageshakes#15107, matrix-org/element-web-rageshakes#15093 matrix-org/element-web-rageshakes#15092 and matrix-org/element-web-rageshakes#15077.
* Fix plain text export saving ([\element-hq#9230](matrix-org/matrix-react-sdk#9230)). Contributed by @jryans.
* Add missing space in SecurityRoomSettingsTab ([\element-hq#9222](matrix-org/matrix-react-sdk#9222)). Contributed by @gefgu.
* Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\element-hq#9209](matrix-org/matrix-react-sdk#9209)). Fixes element-hq#21369.
* Fix progress bar regression throughout the app ([\element-hq#9219](matrix-org/matrix-react-sdk#9219)). Fixes element-hq#23121.
* Reuse empty string & space string logic for event types in devtools ([\element-hq#9218](matrix-org/matrix-react-sdk#9218)). Fixes element-hq#23115.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Sep 15, 2022
@su-ex
Merge tag 'v3.54.0' into sc
56e7672 
* Device manager - hide unverified security recommendation when only current session is unverified ([\matrix-org#9228](matrix-org#9228)). Contributed by @kerryarchibald.
* Device manager - scroll to filtered list from security recommendations ([\matrix-org#9227](matrix-org#9227)). Contributed by @kerryarchibald.
* Device manager - updated dropdown style in filtered device list ([\matrix-org#9226](matrix-org#9226)). Contributed by @kerryarchibald.
* Device manager - device type and verification icons on device tile ([\matrix-org#9197](matrix-org#9197)). Contributed by @kerryarchibald.
* Description of DM room with more than two other people is now being displayed correctly ([\matrix-org#9231](matrix-org#9231)). Fixes element-hq/element-web#23094.
* Fix voice messages with multiple composers ([\matrix-org#9208](matrix-org#9208)). Fixes element-hq/element-web#23023. Contributed by @grimhilt.
* Fix suggested rooms going missing ([\matrix-org#9236](matrix-org#9236)). Fixes element-hq/element-web#23190.
* Fix tooltip infinitely recursing ([\matrix-org#9235](matrix-org#9235)). Fixes matrix-org/element-web-rageshakes#15107, matrix-org/element-web-rageshakes#15093 matrix-org/element-web-rageshakes#15092 and matrix-org/element-web-rageshakes#15077.
* Fix plain text export saving ([\matrix-org#9230](matrix-org#9230)). Contributed by @jryans.
* Add missing space in SecurityRoomSettingsTab ([\matrix-org#9222](matrix-org#9222)). Contributed by @gefgu.
* Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\matrix-org#9209](matrix-org#9209)). Fixes element-hq/element-web#21369.
* Fix progress bar regression throughout the app ([\matrix-org#9219](matrix-org#9219)). Fixes element-hq/element-web#23121.
* Reuse empty string & space string logic for event types in devtools ([\matrix-org#9218](matrix-org#9218)). Fixes element-hq/element-web#23115.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weeman1337 weeman1337

Labels
A-DMs O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use room name as room intro matrix-org/matrix-react-sdk
3 participants
@kittykat @germain-gg @weeman1337