Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room unread counts are unreliable (metabug) #3363

Open
5 of 12 tasks
ara4n opened this issue Mar 4, 2017 · 7 comments
Open
5 of 12 tasks

Room unread counts are unreliable (metabug) #3363

ara4n opened this issue Mar 4, 2017 · 7 comments
Labels
A-Notifications A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-GetYourUpdates

Comments

@ara4n
Copy link
Member Author

ara4n commented Mar 4, 2017

i just fixed the autocomplete thing here with https://justineo.github.io/github-hovercard/

@ara4n
Copy link
Member Author

ara4n commented Mar 5, 2017

@vurpo says: "sometimes if I send a message in a room and then immediately switch to another room, the previous room shows as having unread messages, even though the only unread message is my own"

@turt2live
Copy link
Member

I've seen in recent builds of /develop some strang-ish behaviour. Not sure if it is in other builds of Riot.

When I set rooms to 'Mentions Only', there's a good chance (if not 100%) that the room will still update the favicon, but no new badges are present on rooms. Having no badges is expected, however the favicon change is not expected. There does not seem to be a fix for this besides leaving the room.

This only happens on new rooms I join, not existing rooms.

Please let me know if a whole issue should be created for this. I'm on Chrome 58, Windows 10, riot.im/develop. Has happened many times over the last couple weeks.

@ara4n
Copy link
Member Author

ara4n commented Jul 7, 2017

Another variant - despite being scrolled to the bottom, mentions cause the badge to keep firing. http://i.imgur.com/azLdI2D.png

@foss-
Copy link

foss- commented Aug 20, 2017

#3257 and #3263 are closed. would be nice to reflect that in the top summary.

@t3chguy
Copy link
Member

t3chguy commented Aug 20, 2017

@foss- I edited Matthew's post to add checkboxes and mark the Closed issues, is that better?

@fuzzy76
Copy link

fuzzy76 commented Jan 3, 2018

#5698 (closed), #747 (closed) and #2741 (closed) are others. This is really irritating. #4947 seems to have a good grasp of what's causing a large share of these (but I could also be wrong).

turt2live added a commit to turt2live/evelium that referenced this issue Mar 18, 2018
The general idea is that the room service will call into the notification service for each renderable event. This offloads push rule calculations to the notification service.

Notifications and unread counts are both going to be calculated client side. Therefore we can ignore the server values in the sync response. This is because issues like [element-hq/element-web#3363] are inevitable if we try and do a mix of   server and client processing. 

However, to get to that point we need read receipts so we can see what we've read and what we haven't read. Ideally this reliance on read receipts will disappear when this is resolved: element-hq/riot-meta#66

The amount of interaction between the room service and notification service is still relatively undecided. It will call into the notification service for determining if something should notify, however the read receipt parsing needs to somehow update the notification count somewhere.
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely A-Notifications S-Minor Impairs non-critical functionality or suitable workarounds exist and removed P1 labels Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-GetYourUpdates
Projects
None yet
Development

No branches or pull requests

9 participants