-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room unread counts are unreliable (metabug) #3363
Comments
i just fixed the autocomplete thing here with https://justineo.github.io/github-hovercard/ |
@vurpo says: "sometimes if I send a message in a room and then immediately switch to another room, the previous room shows as having unread messages, even though the only unread message is my own" |
I've seen in recent builds of /develop some strang-ish behaviour. Not sure if it is in other builds of Riot. When I set rooms to 'Mentions Only', there's a good chance (if not 100%) that the room will still update the favicon, but no new badges are present on rooms. Having no badges is expected, however the favicon change is not expected. There does not seem to be a fix for this besides leaving the room. This only happens on new rooms I join, not existing rooms. Please let me know if a whole issue should be created for this. I'm on Chrome 58, Windows 10, riot.im/develop. Has happened many times over the last couple weeks. |
Another variant - despite being scrolled to the bottom, mentions cause the badge to keep firing. http://i.imgur.com/azLdI2D.png |
@foss- I edited Matthew's post to add checkboxes and mark the Closed issues, is that better? |
The general idea is that the room service will call into the notification service for each renderable event. This offloads push rule calculations to the notification service. Notifications and unread counts are both going to be calculated client side. Therefore we can ignore the server values in the sync response. This is because issues like [element-hq/element-web#3363] are inevitable if we try and do a mix of server and client processing. However, to get to that point we need read receipts so we can see what we've read and what we haven't read. Ideally this reliance on read receipts will disappear when this is resolved: element-hq/riot-meta#66 The amount of interaction between the room service and notification service is still relatively undecided. It will call into the notification service for determining if something should notify, however the read receipt parsing needs to somehow update the notification count somewhere.
This is a meta-bug to try to track all the sub-bugs related to unreliable badge counts on rooms. Hopefully GH will eventually auto-complete the details here:
The text was updated successfully, but these errors were encountered: