Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent stuck notifications and badge count #3059

Open
Tracked by #3363
kegsay opened this issue Jan 25, 2017 · 14 comments
Open
Tracked by #3363

Persistent stuck notifications and badge count #3059

kegsay opened this issue Jan 25, 2017 · 14 comments
Labels
A-Notifications O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@kegsay
Copy link
Contributor

kegsay commented Jan 25, 2017

What happened:

  1. I got binged in a room. Riot's favicon went to (1) and the room went to (1).
  2. I clicked the room. I read the message. The (1) disappeared on both.
  3. I swapped to another room. The (1) came back on both favicon and room.
  4. I swapped to the room. It disappeared.
  5. Rinse repeat at least 8 times (enough that I demonstrated this to @lukebarnard1 ).

What I expect to happen:

The (1) should disappear and not come back as I was not binged in that room anymore.

What actually happened:

It kept reappearing. I had to mute the room.

@dbkr
Copy link
Member

dbkr commented Jan 26, 2017

I've seen behaviour like this when the server is struggling so this is likely to be the HS trying to decide what our notification count should be.

@kegsay
Copy link
Contributor Author

kegsay commented Jan 26, 2017

Do we get any more information other than the notif count for each room? It'd be nice if Riot-Web could say "I've already binged for event ID ABC123, I'm not going to do it again".

@ara4n
Copy link
Member

ara4n commented Feb 18, 2017

this sounds almost the same as #3060?

@kegsay
Copy link
Contributor Author

kegsay commented Feb 18, 2017

Different - This one the notification did go away for a bit, but then returned. #3060 seems to never go away until you go to a random room.

@turt2live
Copy link
Member

turt2live commented Feb 18, 2017

I managed to encounter something similar to this (and by proxy, #3060 as well) with some help from element-hq/element-meta#486 (so this might actually be invalid/a different issue):

  • Set the room to notify on "All Messages (Loud)"
  • Receive a couple messages when not looking at room
  • Set the room to "Mentions Only" or lower without going into room
    • At this point, the badge next to the room goes away, but the favicon stays stuck
  • Go into room to clear notification from the favicon
  • Carry on and go to other rooms and wait for more messages
  • No badge in room list, favicon gets a nice red mark on it

Edit: Muting the room doesn't help :/

@ara4n ara4n changed the title Persistent notifications Persistent stuck notifications and badge count Mar 4, 2017
@ara4n
Copy link
Member

ara4n commented Mar 4, 2017

related to #2427

@jurf
Copy link

jurf commented Oct 15, 2017

I have a stuck notification too, it’s been like that for ages. Driving me nuts.

@grahamperrin
Copy link

@jurf if you sequentially browse every room where you're a member, without bothering to page up or down to tell whether there's the thing that caused the notification, then does the notification disappear?

@jurf
Copy link

jurf commented Oct 16, 2017

@grahamperrin I did that once before and it only maybe 1 out of 2 disappear. This time the other one disappeared too. Thanks! (Btw the culprit was the Riot room.)

@grahamperrin
Copy link

@jurf thanks for the feedback. (A couple of days ago I submitted, from within Riot, a bug report that might partially explain your most recent incident. Too soon to tell whether that report equates to an existing issue.)

@aaronraimist
Copy link
Collaborator

aaronraimist commented Jul 4, 2019

May be fixed by matrix-org/matrix-react-sdk#3121

Not fixed for me

@dreamerchris
Copy link
Contributor

I got this too in all my clients so it must be something core that makes this one notification count apear

@daniellekirkwood
Copy link
Contributor

Is this issue still a defect you're experiencing?

We think it needs to be closed - it will stay open for now but will be closed next week if we haven't heard anything.

Thanks!

@turt2live
Copy link
Member

The slow server case has not been fixed, nor has the switching between notification levels (to my knowledge)

@MadLittleMods MadLittleMods added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

10 participants