Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes new device detections banner problems #8536

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

BillCarsonFr
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fixes several problems with "new login, was this you", "You have unverified session" banners.

For rust flavor:

  • A missing binding for device first time seen was causing the "new login" banner to not show up. Depends on this rust sdk PR

Other problems:

  • After tapping the "new login" banner to start the verification a "you have unverified session" banner was poping up under the verification bottomsheet and was not removed
  • Under some conditions the "new login" banner was not dismissed after the device was verified, causing some users to click twice and perform 2 verifications. Fixes Got asked twice about verification #8353

Screenshots / GIFs

Before:

unwanted_you_have_unverified.webm

After:

after.webm

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/new_login_detection branch from 4407e21 to 51c4dfc Compare June 26, 2023 08:49
@BillCarsonFr BillCarsonFr requested review from a team and Florian14 and removed request for a team June 26, 2023 09:03
@BillCarsonFr BillCarsonFr added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jun 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (static review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got asked twice about verification
2 participants