Skip to content

Conversation

@yostyle
Copy link
Contributor

@yostyle yostyle commented Apr 4, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Changelog already exists from #8305

Motivation and context

#8268

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested review from a team, giomfo and jonnyandrew and removed request for a team April 4, 2023 15:15
@yostyle yostyle marked this pull request as ready for review April 4, 2023 15:16
@yostyle yostyle requested review from a team, Florian14, bmarty and ganfra and removed request for a team, Florian14, bmarty and jonnyandrew April 4, 2023 16:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's ok :D
The code is becoming a bit hard to follow, maybe we should handle this outside of a flow..

@yostyle yostyle merged commit 99aa949 into develop Apr 12, 2023
@yostyle yostyle deleted the yostyle/fix_unread_marker branch April 12, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants