Skip to content

Truncated message in the pills #8260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yostyle merged 2 commits into from
Mar 23, 2023
Merged

Truncated message in the pills #8260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1212121
ellipsize pills
yostyle Mar 22, 2023
863572d
Add changelog
yostyle Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8218.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Long name are truncated in the pills
11 changes: 11 additions & 0 deletions vector/src/main/java/im/vector/app/features/html/PillImageSpan.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ import android.content.Context
import android.content.res.ColorStateList
import android.graphics.Canvas
import android.graphics.Paint
import android.graphics.Rect
import android.graphics.drawable.Drawable
import android.text.TextUtils
import android.text.style.ReplacementSpan
import android.widget.TextView
import androidx.annotation.UiThread
Expand Down Expand Up @@ -101,6 +103,15 @@ class PillImageSpan(
val transY: Int = y + (fm.descent + fm.ascent - pillDrawable.bounds.bottom) / 2
canvas.save()
canvas.translate(x, transY.toFloat())

val rect = Rect()
canvas.getClipBounds(rect)
val maxWidth = rect.right
if (pillDrawable.intrinsicWidth > maxWidth) {
pillDrawable.setBounds(0, 0, maxWidth, pillDrawable.intrinsicHeight)
pillDrawable.ellipsize = TextUtils.TruncateAt.END
}

pillDrawable.draw(canvas)
canvas.restore()
}
Expand Down