Skip to content

Truncated message in the pills #8260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yostyle merged 2 commits into from
Mar 23, 2023
Merged

Truncated message in the pills #8260

yostyle merged 2 commits into from
Mar 23, 2023

Conversation

@yostyle
Copy link
Contributor

@yostyle yostyle commented Mar 22, 2023 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

#8218

Screenshots / GIFs

Before After
image Screenshot_20230322-185642

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@yostyle yostyle requested review from a team, giomfo and jmartinesp and removed request for a team March 22, 2023 17:56
@yostyle yostyle changed the title Truncated pills Truncated message in the pills Mar 22, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

jmartinesp
jmartinesp approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yostyle yostyle merged commit 54457c1 into develop Mar 23, 2023
@yostyle yostyle deleted the yostyle/truncated_pills branch March 23, 2023 08:01
@SpiritCroc SpiritCroc mentioned this pull request Apr 5, 2023
Closed
Kirchmaus pushed a commit to SchildiChat/SchildiChat-android that referenced this pull request Apr 5, 2023
@SpiritCroc
Fix FooteredTextView measurements for overlong pill spans
5ea7f03 
Together with element-hq#8260,
fixes #28

Change-Id: I3c11d1ec89383330fedb4a958d70e89047915024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

@giomfo giomfo Awaiting requested review from giomfo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yostyle @jmartinesp