[Devices Management] Refactor some code to improve testability (PSG-701) #7044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaturel
changed the title
mnaturel
force-pushed
the
feature/mna/clean-vm-for-dm-v2
branch
from
0ed1673
to
b91def8
Compare
mnaturel
force-pushed
the
feature/mna/session-overview-screen
branch
from
eb59a53
to
682905d
Compare
mnaturel
force-pushed
the
feature/mna/clean-vm-for-dm-v2
branch
from
b91def8
to
2592bc3
Compare
mnaturel
requested review from
a team,
ericdecanini,
yostyle and
onurays
and removed request for
a team and
ericdecanini
onurays
reviewed
Sep 7, 2022
| } | ||
|
|
||
| private fun removeVerificationListener() { | ||
| activeSessionHolder.getSafeActiveSession() |
There was a problem hiding this comment.
Nice to see getSafeActiveSession() here.
onurays
reviewed
Sep 7, 2022
| return CurrentSessionCrossSigningInfo( | ||
| deviceId = deviceId, | ||
| isCrossSigningInitialized = mxCrossSigningInfo.getOrNull() != null, | ||
| isCrossSigningVerified = mxCrossSigningInfo.getOrNull()?.isTrusted() == true |
There was a problem hiding this comment.
I like to use mxCrossSigningInfo.getOrNull()?.isTrusted().orFalse() but of course this is ok too.
There was a problem hiding this comment.
Thanks for the suggestion. I have done the update, I prefer also using the extension method. Updated in 98ca432
onurays
approved these changes
Sep 7, 2022
mnaturel
force-pushed
the
feature/mna/clean-vm-for-dm-v2
branch
from
2592bc3
to
98ca432
Compare
Base automatically changed from
feature/mna/session-overview-screen
to
develop
September 8, 2022 07:18
added 12 commits
September 8, 2022 09:48
mnaturel
force-pushed
the
feature/mna/clean-vm-for-dm-v2
branch
from
9c49ff9
to
45b138e
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Creating a new clean and tested
DevicesViewModelinside the V2 package. Domain layer code has been encapsulated inside UseCases with unit tests.All the code related to the new device management version has been move inside the V2 package.
Motivation and context
Closes #7043
Screenshots / GIFs
Tests
Tested devices
Checklist